[GitHub] [cordova-ios] erisu edited a comment on pull request #1187: test(version): merge component tests into unit tests

[GitBox <gi...@apache.org>]

erisu edited a comment on pull request #1187:
URL: https://github.com/apache/cordova-ios/pull/1187#issuecomment-963900389


   I think the new collection of integration tests is a good idea but let's keep it as a separate PR and in the backlog.
   
   I think we have been trying to push a lot of the major changes for the upcoming release (no ETA) and there is a lot of changes that have more priorities.
   
   Some for example:
   
   * Keeping Cordova node logic in `node_modules`
   * The new `cordova-js` build system.
   
   I agree about the
   > hard to make sure that future contributions maintain that new order.
   
   As for this PR, I already had approved the PR and am OK with the changes. We can think about better testing practices later. I was just making a note of what I was thinking before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org