You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafodion.apache.org by sa...@apache.org on 2017/03/28 15:19:05 UTC
[5/6] incubator-trafodion git commit: Removing commented out code
Removing commented out code
Project: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/commit/45bbb16a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/tree/45bbb16a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/diff/45bbb16a
Branch: refs/heads/master
Commit: 45bbb16a52e7986b56afcad68f12fc02fd0b72bf
Parents: 22ef1e2
Author: Sandhya Sundaresan <sa...@apache.org>
Authored: Tue Mar 28 05:36:56 2017 +0000
Committer: Sandhya Sundaresan <sa...@apache.org>
Committed: Tue Mar 28 05:36:56 2017 +0000
----------------------------------------------------------------------
core/sql/optimizer/BindItemExpr.cpp | 18 +-----------------
1 file changed, 1 insertion(+), 17 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-trafodion/blob/45bbb16a/core/sql/optimizer/BindItemExpr.cpp
----------------------------------------------------------------------
diff --git a/core/sql/optimizer/BindItemExpr.cpp b/core/sql/optimizer/BindItemExpr.cpp
index e2df528..91e1325 100644
--- a/core/sql/optimizer/BindItemExpr.cpp
+++ b/core/sql/optimizer/BindItemExpr.cpp
@@ -6185,23 +6185,7 @@ ItemExpr *Assign::bindNode(BindWA *bindWA)
return boundExpr;
setChild(1, newChild);
}
- /* if ((sourceType == NA_UNKNOWN_TYPE) && (targetType = NA_LOB_TYPE))
- {
- ValueId vid1 = child(1)->castToItemExpr()->getValueId();
-
- SQLVarChar c1(CmpCommon::getDefaultNumeric(MAX_LONG_VARCHAR_DEFAULT_SIZE));
- vid1.coerceType(c1, NA_CHARACTER_TYPE);
-
-
-
- // Add a stringToLob node
- ItemExpr *newChild = new (bindWA->wHeap()) LOBinsert( vid1.getItemExpr(), NULL, LOBoper::STRING_, FALSE);
- newChild->bindNode(bindWA);
- if (bindWA->errStatus())
- return boundExpr;
- setChild(1, newChild);
-
- }*/
+
if ((NOT child(0)->getValueId().getType().
isCompatible(child(1)->getValueId().getType())) &&
(CmpCommon::getDefault(ALLOW_INCOMPATIBLE_OPERATIONS) == DF_ON) &&