[GitHub] [kvrocks] torwig commented on a diff in pull request #1664: Small fix mismatching defaults options value and his comments

["torwig (via GitHub)" <gi...@apache.org>]

torwig commented on code in PR #1664:
URL: https://github.com/apache/kvrocks/pull/1664#discussion_r1290965281


##########
kvrocks.conf:
##########
@@ -547,7 +547,7 @@ rocksdb.row_cache_size 0
 # files opened are always kept open. You can estimate number of files based
 # on target_file_size_base and target_file_size_multiplier for level-based
 # compaction. For universal-style compaction, you can usually set it to -1.
-# Default: 4096
+# Default: 8096

Review Comment:
   This value is 4096 by default: https://github.com/apache/kvrocks/blob/unstable/src/config/config.cc#L166



##########
kvrocks.conf:
##########
@@ -603,7 +603,7 @@ rocksdb.max_background_flushes -1
 # This value represents the maximum number of threads that will
 # concurrently perform a compaction job by breaking it into multiple,
 # smaller ones that are run simultaneously.
-# Default: 2 (i.e. no subcompactions)
+# Default: 2

Review Comment:
   The default value here is 1, according to the source code: https://github.com/apache/kvrocks/blob/unstable/src/config/config.cc#L172



##########
kvrocks.conf:
##########
@@ -647,12 +647,12 @@ rocksdb.wal_size_limit_mb 16384
 # actual size of the unit read from disk may be smaller if
 # compression is enabled.
 #
-# Default: 4KB
+# Default: 16KB

Review Comment:
   4096 is OK here: https://github.com/apache/kvrocks/blob/unstable/src/config/config.cc#L165



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org