[GitHub] [skywalking] Lgmmm opened a new issue, #11129: [Bug]

["Lgmmm (via GitHub)" <gi...@apache.org>]

Lgmmm opened a new issue, #11129:
URL: https://github.com/apache/skywalking/issues/11129

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache SkyWalking Component
   
   Java Agent (apache/skywalking-java)
   
   ### What happened
   
   If the plug-in defines that the target class to be intercepted supports hot loading, it will be loaded by a new class loader each time the target class is hot loaded.  Triggering "org.apache.skywalking.apm.agent.SkyWalkingAgent$Transformer.transform()" into and this is a new instance, Lead to "org.apache.skywalking.apm.agent.core.plugin.loader. InterceptorInstanceLoader$EXTEND_PLUGIN_CLASSLOADERS" every time a add new classl oader, map holds a reference to the classloader, which will overflow the application metaspace after multiple hot loads
   
   ### What you expected to happen
   
   the plug-in defines that the target class to be intercepted supports hot loading
   
   ### How to reproduce
   
   The premise is that the target class intercepted by the plug-in supports the target class supports hot loading, and then triggers the target class hot loading repeatedly
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #11129: [Bug] InterceptorInstanceLoader java.lang.OutOfMemoryError

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng closed issue #11129: [Bug] InterceptorInstanceLoader java.lang.OutOfMemoryError
URL: https://github.com/apache/skywalking/issues/11129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #11129: [Bug] InterceptorInstanceLoader java.lang.OutOfMemoryError

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on issue #11129:
URL: https://github.com/apache/skywalking/issues/11129#issuecomment-1647992961

   Don't support hot load, as load loading itself is creating new class loader everytime.
   And it is not a good practice in product. We have to maintain this to avoid accessing plugin failure cross class loader.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org