You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/02/01 02:38:19 UTC
[GitHub] [spark] LuciferYang commented on a diff in pull request #39712: [SPARK-42172][CONNECT] Scala Client Mima Compatibility Tests
LuciferYang commented on code in PR #39712:
URL: https://github.com/apache/spark/pull/39712#discussion_r1092703174
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -136,4 +144,37 @@
</plugin>
</plugins>
</build>
+
+ <!-- To skip client integration test, use 'mvn clean package -DskipJvmClientITs=true' -->
Review Comment:
No need to add this profile, We can use `-Dtest.exclude.tags=org.apache.spark.sql.connect.client.util.ClientIntegrationTest` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org