You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Eric Pugh (Created) (JIRA)" <ji...@apache.org> on 2012/03/30 23:03:31 UTC
[jira] [Created] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Migrate enable/disable Ping from JSP to PingRequestHandler
----------------------------------------------------------
Key: SOLR-3301
URL: https://issues.apache.org/jira/browse/SOLR-3301
Project: Solr
Issue Type: Improvement
Affects Versions: 4.0
Reporter: Eric Pugh
Fix For: 4.0
My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Matt Overstreet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Overstreet updated SOLR-3301:
----------------------------------
Attachment: health_check_admin_consolidate.patch
consolidated patch. includes all changes from the other attached patches as requested.
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, health_check_admin_consolidate.patch, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Stefan Matheis (steffkes) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258861#comment-13258861 ]
Stefan Matheis (steffkes) commented on SOLR-3301:
-------------------------------------------------
Hm, i'm not completely happy with this one. if you're using it w/ the example-configuration, there is no healthcheck file defined. the ui will indicate a disabled status and if you try to enable it, it will fail - but w/o any visual notification?
In addition to that, the Ping Handler is only displaying a {{status: "healthcheck not configured"}} information, while using a {{200 OK}} Status, can we have something like a {{503 Service Unavailable}}? To show that it's not "ready" at all?
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, health_check_admin_consolidate.patch, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260426#comment-13260426 ]
Chris Male commented on SOLR-3301:
----------------------------------
As Stefan found out, the problem was that a locale wasn't specified in the toUpperCase() call.
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, SOLR-3301-tests.patch, SOLR-3301.patch, health_check_admin_consolidate.patch, health_check_admin_consolidate2.patch, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Eric Pugh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242745#comment-13242745 ]
Eric Pugh commented on SOLR-3301:
---------------------------------
Anyone have thoughts on where the disable/enable UI component should go?
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Matt Overstreet (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Overstreet updated SOLR-3301:
----------------------------------
Attachment: healthcheck-ui.png
example of new ui for health check
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, healthcheck-ui.png, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Reopened] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Stefan Matheis (steffkes) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Matheis (steffkes) reopened SOLR-3301:
---------------------------------------------
https://builds.apache.org/job/Lucene-Solr-tests-only-trunk/13442/testReport/junit/org.apache.solr.handler/PingRequestHandlerTest/testPing/ is failing
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, SOLR-3301.patch, health_check_admin_consolidate.patch, health_check_admin_consolidate2.patch, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Eric Pugh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Pugh updated SOLR-3301:
----------------------------
Attachment: PingRequestHandlerTest.java
Supporting unit tests.
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Matt Overstreet (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245934#comment-13245934 ]
Matt Overstreet commented on SOLR-3301:
---------------------------------------
Let me know if you have any thoughts on the UI elements I've added. I also refactored the admin css a bit to support using dd and dt with the same style as the statistics panel, but in other place in the admin.
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Eric Pugh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Pugh updated SOLR-3301:
----------------------------
Attachment: ping_request_handler.patch
Patch to PingRequestHandler
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Fix For: 4.0
>
> Attachments: ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Stefan Matheis (steffkes) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Matheis (steffkes) resolved SOLR-3301.
---------------------------------------------
Resolution: Fixed
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, SOLR-3301-tests.patch, SOLR-3301.patch, health_check_admin_consolidate.patch, health_check_admin_consolidate2.patch, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Stefan Matheis (steffkes) (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Matheis (steffkes) reassigned SOLR-3301:
-----------------------------------------------
Assignee: Stefan Matheis (steffkes)
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Matt Overstreet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259213#comment-13259213 ]
Matt Overstreet commented on SOLR-3301:
---------------------------------------
Looks great,please go ahead.
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, SOLR-3301.patch, health_check_admin_consolidate.patch, health_check_admin_consolidate2.patch, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Stefan Matheis (steffkes) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Matheis (steffkes) updated SOLR-3301:
--------------------------------------------
Attachment: SOLR-3301.patch
Thanks Matt, i've changed the following things:
1) Lucene is using two spaces for indentation, i replaced the tabs.
2) Your Patch did not compile:
{code}+ if (healthcheck == null) {
+ throw new SolrException(SolrException.ErrorCode.SERVICE_UNAVAILABLE x,
+ "No healthcheck file defined.");
+ }{code}
was failing with the following error(s):
{code}common.compile-core:
[mkdir] Created dir: /opt/solr-trunk/solr/build/solr-core/classes/java
[javac] Compiling 564 source files to /opt/solr-trunk/solr/build/solr-core/classes/java
[javac] /opt/solr-trunk/solr/core/src/java/org/apache/solr/handler/PingRequestHandler.java:141: ')' expected
[javac] throw new SolrException(SolrException.ErrorCode.SERVICE_UNAVAILABLE x,
[javac] ^
[javac] /opt/solr-trunk/solr/core/src/java/org/apache/solr/handler/PingRequestHandler.java:141: illegal start of expression
[javac] throw new SolrException(SolrException.ErrorCode.SERVICE_UNAVAILABLE x,
[javac] ^
[javac] /opt/solr-trunk/solr/core/src/java/org/apache/solr/handler/PingRequestHandler.java:141: ';' expected
[javac] throw new SolrException(SolrException.ErrorCode.SERVICE_UNAVAILABLE x,
[javac] ^
[javac] /opt/solr-trunk/solr/core/src/java/org/apache/solr/handler/PingRequestHandler.java:142: illegal start of expression
[javac] "No healthcheck file defined.");
[javac] ^
[javac] 4 errors{code}
3) I would not expect a {{BAD_REQUEST}}-Error if Ping is not configured?
{code}+ case STATUS:
+ if( healthcheck == null){
+ SolrException e = new SolrException(SolrException.ErrorCode.BAD_REQUEST, "healthcheck not configured");
+ rsp.setException(e);
+ }{code}
It's not the Clients Fault (which is, what the 4xx-Status-Range is meant for) - i changed this one into a {{SERVICE_UNAVAILABLE}}, which reflects the behavior more correct imho.
Let me know if these are okay for you, then i'll go ahead and commit this one
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, SOLR-3301.patch, health_check_admin_consolidate.patch, health_check_admin_consolidate2.patch, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Eric Pugh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252423#comment-13252423 ]
Eric Pugh commented on SOLR-3301:
---------------------------------
Can this be committed?
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Stefan Matheis (steffkes) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Matheis (steffkes) resolved SOLR-3301.
---------------------------------------------
Resolution: Fixed
Committed in r1329263
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, SOLR-3301.patch, health_check_admin_consolidate.patch, health_check_admin_consolidate2.patch, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Stefan Matheis (steffkes) (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252450#comment-13252450 ]
Stefan Matheis (steffkes) commented on SOLR-3301:
-------------------------------------------------
Would you mind to create one (combined) Patch for me? Then i'd go ahead and commit this one
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Stefan Matheis (steffkes) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Matheis (steffkes) updated SOLR-3301:
--------------------------------------------
Attachment: SOLR-3301-tests.patch
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, SOLR-3301-tests.patch, SOLR-3301.patch, health_check_admin_consolidate.patch, health_check_admin_consolidate2.patch, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Matt Overstreet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Overstreet updated SOLR-3301:
----------------------------------
Attachment: health_check_admin_consolidate2.patch
Updated to address Stefan's great issue list. disabled healthcheck now returns with a 503 status.
Also, healthcheck status display works correctly if the healthcheck file is commented out at server start (the entire control is grayed out).
Let me know if I need to make any more tweaks!
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Stefan Matheis (steffkes)
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, health_check_admin_consolidate.patch, health_check_admin_consolidate2.patch, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Matt Overstreet (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Overstreet updated SOLR-3301:
----------------------------------
Attachment: healthcheckenable.patch
Patch for to include ui elements for healthcheck on the admin dashboard. Allows enabling and disabling of healthcheck through the admin.
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3301) Migrate enable/disable Ping from JSP
to PingRequestHandler
Posted by "Stefan Matheis (steffkes) (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Matheis (steffkes) updated SOLR-3301:
--------------------------------------------
Component/s: web gui
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
> Key: SOLR-3301
> URL: https://issues.apache.org/jira/browse/SOLR-3301
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Fix For: 4.0
>
> Attachments: PingRequestHandlerTest.java, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org