You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by GitBox <gi...@apache.org> on 2022/02/08 17:58:32 UTC
[GitHub] [flume] tmgstevens opened a new pull request #351: Docker
tmgstevens opened a new pull request #351:
URL: https://github.com/apache/flume/pull/351
Draft docker build and integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@flume.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flume] busbey commented on a change in pull request #351: Docker
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #351:
URL: https://github.com/apache/flume/pull/351#discussion_r821121308
##########
File path: flume-ng-dist/Dockerfile
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+ARG IMAGE_NAME=adoptopenjdk/openjdk8
+ARG IMAGE_TAG=centos-jre
+
+FROM ${IMAGE_NAME}:${IMAGE_TAG}
+
+ARG ASSEMBLY_VERSION
+ARG MAINTAINER="Apache Flume <de...@flume.apache.org>"
Review comment:
the MAINTAINER keyword was deprecated a bit ago. I believe the preferred idiomatic way now is via a label:
```
LABEL org.opencontainers.image.authors="dev@flume.apache.org"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@flume.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flume] tmgstevens commented on a change in pull request #351: Docker
Posted by GitBox <gi...@apache.org>.
tmgstevens commented on a change in pull request #351:
URL: https://github.com/apache/flume/pull/351#discussion_r821824821
##########
File path: flume-ng-dist/Dockerfile
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+ARG IMAGE_NAME=adoptopenjdk/openjdk8
+ARG IMAGE_TAG=centos-jre
+
+FROM ${IMAGE_NAME}:${IMAGE_TAG}
+
+ARG ASSEMBLY_VERSION
+ARG MAINTAINER="Apache Flume <de...@flume.apache.org>"
Review comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@flume.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flume] busbey commented on pull request #351: Docker
Posted by GitBox <gi...@apache.org>.
busbey commented on pull request #351:
URL: https://github.com/apache/flume/pull/351#issuecomment-1061155347
is there a jira that describes the goals of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@flume.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org