You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/08/04 11:19:02 UTC
[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4659: HDFS-16700. RBF: Record the real client IP carried by the Router in the NameNode log
ZanderXu commented on code in PR #4659:
URL: https://github.com/apache/hadoop/pull/4659#discussion_r937660662
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java:
##########
@@ -121,6 +121,44 @@ public String toString() {
return str;
}
+ private static String parseSpecialValue(String content, String key) {
Review Comment:
This method is duplicate with `NameNode#parseSpecialValue`, can you remove the method in `NameNode.class` and use this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org