[GitHub] [maven] elharo commented on pull request #1033: replace deprecated methods that don't properly handle encoding

["elharo (via GitHub)" <gi...@apache.org>]

elharo commented on PR #1033:
URL: https://github.com/apache/maven/pull/1033#issuecomment-1458804070

   Test cases here would be iffy, because the behavior is system dependent and most of the time this will just work. However there can be flaky behavior with non-ASCII characters when the Locale is something uncommon like Turkish. Generally when parsing XML one should let the parser detect the encoding, rather than trying to guess it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org