You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2022/09/23 15:39:20 UTC
[GitHub] [karaf] awrb opened a new pull request, #1626: [KARAF-7068] add instance:package command to compress an instance into zip/tar.gz
awrb opened a new pull request, #1626:
URL: https://github.com/apache/karaf/pull/1626
Not sure if this one was up for grabs since @jbonofre is already assigned on Jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on a diff in pull request #1626: [KARAF-7068] add instance:package command to compress an instance into zip/tar.gz
Posted by GitBox <gi...@apache.org>.
jbonofre commented on code in PR #1626:
URL: https://github.com/apache/karaf/pull/1626#discussion_r994228664
##########
assemblies/features/standard/src/main/feature/feature.xml:
##########
@@ -630,6 +630,7 @@ update = manager
</feature>
<feature name="instance" description="Provide Instance support" version="${project.version}">
+ <bundle dependency="true">mvn:org.apache.commons/commons-compress/${commons-compress.version}</bundle>
Review Comment:
@awrb any update about removing `commons-compress` and using only zip ? I can do that if you prefer. Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] asfgit closed pull request #1626: [KARAF-7068] add instance:package command to compress an instance into zip
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1626: [KARAF-7068] add instance:package command to compress an instance into zip
URL: https://github.com/apache/karaf/pull/1626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] awrb commented on a diff in pull request #1626: [KARAF-7068] add instance:package command to compress an instance into zip
Posted by GitBox <gi...@apache.org>.
awrb commented on code in PR #1626:
URL: https://github.com/apache/karaf/pull/1626#discussion_r995991814
##########
assemblies/features/standard/src/main/feature/feature.xml:
##########
@@ -630,6 +630,7 @@ update = manager
</feature>
<feature name="instance" description="Provide Instance support" version="${project.version}">
+ <bundle dependency="true">mvn:org.apache.commons/commons-compress/${commons-compress.version}</bundle>
Review Comment:
I removed `commons-compress` dependency and just left the zip option. Sadly maintaining file permissions (e.g. 0755 in bin/karaf) does not seem to work. Seems to be a bug/limitation in JDK:
https://bugs.openjdk.org/browse/JDK-6194856
https://stackoverflow.com/questions/10699334/change-permission-of-a-zipentry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on a diff in pull request #1626: [KARAF-7068] add instance:package command to compress an instance into zip/tar.gz
Posted by GitBox <gi...@apache.org>.
jbonofre commented on code in PR #1626:
URL: https://github.com/apache/karaf/pull/1626#discussion_r995722441
##########
assemblies/features/standard/src/main/feature/feature.xml:
##########
@@ -630,6 +630,7 @@ update = manager
</feature>
<feature name="instance" description="Provide Instance support" version="${project.version}">
+ <bundle dependency="true">mvn:org.apache.commons/commons-compress/${commons-compress.version}</bundle>
Review Comment:
I think it's fine to only generate zip archive (not need to create tar.gz).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on a diff in pull request #1626: [KARAF-7068] add instance:package command to compress an instance into zip
Posted by GitBox <gi...@apache.org>.
jbonofre commented on code in PR #1626:
URL: https://github.com/apache/karaf/pull/1626#discussion_r996253833
##########
assemblies/features/standard/src/main/feature/feature.xml:
##########
@@ -630,6 +630,7 @@ update = manager
</feature>
<feature name="instance" description="Provide Instance support" version="${project.version}">
+ <bundle dependency="true">mvn:org.apache.commons/commons-compress/${commons-compress.version}</bundle>
Review Comment:
Yes, it's normal in a zip file. Let's start with this first functionnality, we will improve on user requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on pull request #1626: [KARAF-7068] add instance:package command to compress an instance into zip/tar.gz
Posted by GitBox <gi...@apache.org>.
jbonofre commented on PR #1626:
URL: https://github.com/apache/karaf/pull/1626#issuecomment-1256378488
@awrb good one ! Let me review it, but it's exactly what I had in mind. Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] awrb commented on a diff in pull request #1626: [KARAF-7068] add instance:package command to compress an instance into zip/tar.gz
Posted by GitBox <gi...@apache.org>.
awrb commented on code in PR #1626:
URL: https://github.com/apache/karaf/pull/1626#discussion_r995411413
##########
assemblies/features/standard/src/main/feature/feature.xml:
##########
@@ -630,6 +630,7 @@ update = manager
</feature>
<feature name="instance" description="Provide Instance support" version="${project.version}">
+ <bundle dependency="true">mvn:org.apache.commons/commons-compress/${commons-compress.version}</bundle>
Review Comment:
I will modify the .zip today but not sure about .tar.gz. I'll look into the code of `commons-compress` how to do it. I'll ask you to take over if it takes too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org