[GitHub] [helix] kaisun2000 edited a comment on issue #1371: fix TestCrushAutoRebalanceNonRack.testLackEnoughInstances

[GitBox <gi...@apache.org>]

kaisun2000 edited a comment on issue #1371:
URL: https://github.com/apache/helix/issues/1371#issuecomment-694535151


   The root cause seems to be at restarting the participant at `testLackEnoughLiveInstances`
   
   ```
       for (int i = 2; i < _participants.size(); i++) {
         _participants.get(i).syncStart();
       }
   
   ```
   
   In fact, participant can't be restart with syncStop before, we have to create a new participant before fixing life cycle of zkclient in CB issue. 
   
   see the right way to do it, in TestWagedRebalancce
   
   ```
   
       // restart the participants within the zone
       for (int i = 2; i < _participants.size(); i++) {
         MockParticipantManager p = _participants.get(i);
         MockParticipantManager newNode =
             new MockParticipantManager(ZK_ADDR, CLUSTER_NAME, p.getInstanceName());
         _participants.set(i, newNode);
         newNode.syncStart();
       }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org