You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Hengruo Zhang (Jira)" <ji...@apache.org> on 2019/09/05 23:54:00 UTC
[jira] [Commented] (ARROW-6408) [Rust] Use "if cfg!" pattern in
SIMD kernel implementations
[ https://issues.apache.org/jira/browse/ARROW-6408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923824#comment-16923824 ]
Hengruo Zhang commented on ARROW-6408:
--------------------------------------
Hi, I am starting to walk through the Rust codebase and would like to contribute. I think this ticket is a good entry point. Here is my PR: [https://github.com/apache/arrow/pull/5303]
Any comments are welcome. Thanks!
> [Rust] Use "if cfg!" pattern in SIMD kernel implementations
> -----------------------------------------------------------
>
> Key: ARROW-6408
> URL: https://issues.apache.org/jira/browse/ARROW-6408
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Rust
> Affects Versions: 0.14.1
> Reporter: Paddy Horan
> Priority: Minor
> Labels: beginner, pull-request-available
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are a few places in the SIMD kernels where we have to use "#[allow(unreachable_code)]". In these cases it would be better to use the "if cfg!" pattern
--
This message was sent by Atlassian Jira
(v8.3.2#803003)