You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shashbha14 (via GitHub)" <gi...@apache.org> on 2026/04/27 18:43:49 UTC
[PR] Fix Edit Connection dialog: add lazyMount to prevent JSON editor infinite loading [airflow]
shashbha14 opened a new pull request, #65969:
URL: https://github.com/apache/airflow/pull/65969
Closes #65954
'EditConnectionButton' was missing 'lazyMount' and 'unmountOnExit' on 'Dialog.Root', causing the Monaco JSON editor to mount hidden with zero dimensions and get stuck on "Loading...".
Added both props to match `AddConnectionButton` which works correctly.
> I used Claude (claude.ai) as an AI assistant for parts of this implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Edit Connection dialog: add lazyMount to prevent JSON editor infinite loading [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #65969:
URL: https://github.com/apache/airflow/pull/65969#issuecomment-4434226571
### Backport successfully created: v3-2-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-2-test</td>
<td><a href="https://github.com/apache/airflow/pull/66828"><img src="https://img.shields.io/badge/PR-66828-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Edit Connection dialog: add lazyMount to prevent JSON editor infinite loading [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #65969:
URL: https://github.com/apache/airflow/pull/65969#issuecomment-4429798077
LGTM, @bbovenzi can you review this as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Edit Connection dialog: add lazyMount to prevent JSON editor infinite loading [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #65969:
URL: https://github.com/apache/airflow/pull/65969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org