You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/25 11:12:04 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #7481: [AIRFLOW-6862][WIP] Do not check the freshness of fresh DAG

mik-laj commented on a change in pull request #7481: [AIRFLOW-6862][WIP] Do not check the freshness of fresh DAG
URL: https://github.com/apache/airflow/pull/7481#discussion_r383813761
 
 

 ##########
 File path: tests/jobs/test_scheduler_job.py
 ##########
 @@ -1010,7 +1010,7 @@ def test_process_dags_not_create_dagrun_for_subdags(self):
         scheduler._process_task_instances = mock.MagicMock()
         scheduler.manage_slas = mock.MagicMock()
 
-        scheduler._process_dags(self.dagbag, [dag] + dag.subdags, [])
+        scheduler._process_dags([dag] + dag.subdags, [])
 
 Review comment:
   In another PR I deletes the tis_out parameter completely.  This parameter is also required because this method returns values using this list. Unfortunately, we do not have an assertion in the tests. In real code is always required. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services