[GitHub] HyukjinKwon commented on a change in pull request #23685: [SPARK-26771][CORE][GRAPHX] Make .unpersist(), .destroy() consistently non-blocking by default

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #23685: [SPARK-26771][CORE][GRAPHX] Make .unpersist(), .destroy() consistently non-blocking by default
URL: https://github.com/apache/spark/pull/23685#discussion_r252133179
 
 

 ##########
 File path: python/pyspark/rdd.py
 ##########
 @@ -244,13 +244,13 @@ def persist(self, storageLevel=StorageLevel.MEMORY_ONLY):
         self._jrdd.persist(javaStorageLevel)
         return self
 
-    def unpersist(self):
+    def unpersist(self, blocking=False):
 
 Review comment:
   To be strict, we could add like:
   
   ```
           .. versionchanged:: 3.0
              Added optional `blocking` to specify blocking Whether to block until all
              blocks are deleted.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org