You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "shunping (via GitHub)" <gi...@apache.org> on 2026/06/22 11:57:23 UTC
[PR] Update pandas version upper bound to support python 3.14 [beam]
shunping opened a new pull request, #39056:
URL: https://github.com/apache/beam/pull/39056
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pandas version upper bound to support python 3.14 [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39056:
URL: https://github.com/apache/beam/pull/39056#issuecomment-4771335791
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pandas version upper bound to support python 3.14 [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #39056:
URL: https://github.com/apache/beam/pull/39056#discussion_r3454651466
##########
sdks/python/apache_beam/dataframe/frames.py:
##########
@@ -5050,11 +5050,19 @@ def get_dummies(self, **kwargs):
cat.split(sep=kwargs.get('sep', '|')) for cat in dtype.categories
]
+ # Find the name pandas uses for the NaN column in get_dummies().
+ # Older pandas versions (<2.3.0) use 'nan', whereas newer versions
+ # use 'NaN'. We dynamically detect it by running a minimal local operation.
+ dummy_nan_col = pd.Series(
+ ['a', None], dtype='category').str.get_dummies().columns.difference(
+ ['a'])[0]
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pandas version upper bound to support python 3.14 [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #39056:
URL: https://github.com/apache/beam/pull/39056#issuecomment-4771325964
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the project's pandas dependency to support Python 3.14, addressing critical segmentation faults encountered during testing. It includes necessary adjustments to handle behavioral changes in pandas 2.3.0+ regarding how null values are represented in dummy columns, ensuring the codebase remains compatible with both older and newer versions of the library.
### Highlights
* **Dependency Update**: Updated the pandas version upper bound from <2.3 to <2.4 in setup.py to support Python 3.14 and resolve segmentation faults.
* **Compatibility Fix**: Implemented dynamic detection of the NaN column name in get_dummies() to ensure compatibility across different pandas versions (2.2.x vs 2.3.x+).
* **Test Infrastructure**: Introduced PD_FULL_VERSION to allow for more granular version checks in test suites, ensuring robust test execution across pandas releases.
<details>
<summary><b>New Features</b></summary>
🧠You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pandas version upper bound to support python 3.14 [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping merged PR #39056:
URL: https://github.com/apache/beam/pull/39056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pandas version upper bound to support python 3.14 [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #39056:
URL: https://github.com/apache/beam/pull/39056#discussion_r3454414495
##########
sdks/python/apache_beam/dataframe/frames.py:
##########
@@ -5050,11 +5050,19 @@ def get_dummies(self, **kwargs):
cat.split(sep=kwargs.get('sep', '|')) for cat in dtype.categories
]
+ # Find the name pandas uses for the NaN column in get_dummies().
+ # Older pandas versions (<2.3.0) use 'nan', whereas newer versions
+ # use 'NaN'. We dynamically detect it by running a minimal local operation.
+ dummy_nan_col = pd.Series(
+ ['a', None], dtype='category').str.get_dummies().columns.difference(
+ ['a'])[0]
Review Comment:
Running a dynamic pandas operation (creating a `Series`, calling `str.get_dummies()`, and computing index differences) on every invocation of `get_dummies()` introduces unnecessary runtime overhead and could potentially raise an `IndexError` if the returned columns structure changes in future pandas versions.
Since the column name used for NaN values is statically determined by the installed pandas version, we can use a simple and safe version check instead. This avoids any runtime overhead and is much more robust.
```suggestion
# Find the name pandas uses for the NaN column in get_dummies().
# Older pandas versions (<2.3.0) use 'nan', whereas newer versions
# use 'NaN'.
import re
try:
pd_version = tuple(int(x) for x in re.findall('[0-9]+', pd.__version__)[0:2])
except Exception:
pd_version = (2, 3)
dummy_nan_col = 'NaN' if pd_version >= (2, 3) else 'nan'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pandas version upper bound to support python 3.14 [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #39056:
URL: https://github.com/apache/beam/pull/39056#issuecomment-4771323946
r: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org