Q: Placement of generators (FIXME in forrest.xmap )

[Ferdinand Soethe <fe...@apache.org>]

Any reason not to move these to sitemap.xmap?

> <!-- FIXME (JJP): This should not be here. Should be define on sitemap -->
>   <map:generators default="file">
>       <map:generator name="html"      src="org.apache.cocoon.generation.HTMLGenerator">
>         <jtidy-config>WEB-INF/jtidy.properties</jtidy-config>
>       </map:generator>
>       <map:generator name="text2xml" logger="sitemap.generator.textgenerator"
>                      src="org.apache.cocoon.generation.TextGenerator">
>        <parameter name="localizable" value="true"/>
>       </map:generator>
>       <map:generator name="exception"
>                   src="org.apache.cocoon.generation.ParseExceptionGenerator"/>
>                   
>     </map:generators>

And why are these already in sitemap.xmap but commented out?

> <!--
>       <map:generator name="html"      src="org.apache.cocoon.generation.HTMLGenerator">
>         <jtidy-config>jtidy.properties</jtidy-config>
>       </map:generator>
>       <map:generator name="directory" src="org.apache.cocoon.generation.DirectoryGenerator" />
>       -->


--
Ferdinand Soethe

Re: Q: Placement of generators (FIXME in forrest.xmap )

[Ferdinand Soethe <fe...@apache.org>]

David Crossley wrote:

> This was discussed on the dev list a few weeks ago.
> I think that the answer was that someone needs to go
> through all the sitemaps, plugins included, and move
> any common definitions up to the main core sitemap.
> For all components, not just generators.

> Any declaration that is not common but specific
> to one particular sitemap, should probably remain
> there. WDYT?

Any reason not to start with this one alone? If it is that simple I'd
just move it.

--
Ferdinand Soethe

Re: Q: Placement of generators (FIXME in forrest.xmap )

[David Crossley <cr...@apache.org>]

Ferdinand Soethe wrote:
> Any reason not to move these to sitemap.xmap?

This was discussed on the dev list a few weeks ago.
I think that the answer was that someone needs to go
through all the sitemaps, plugins included, and move
any common definitions up to the main core sitemap.
For all components, not just generators.

Any declaration that is not common but specific
to one particular sitemap, should probably remain
there. WDYT?

> > <!-- FIXME (JJP): This should not be here. Should be define on sitemap -->
> >   <map:generators default="file">
> >       <map:generator name="html"      src="org.apache.cocoon.generation.HTMLGenerator">
> >         <jtidy-config>WEB-INF/jtidy.properties</jtidy-config>
> >       </map:generator>
> >       <map:generator name="text2xml" logger="sitemap.generator.textgenerator"
> >                      src="org.apache.cocoon.generation.TextGenerator">
> >        <parameter name="localizable" value="true"/>
> >       </map:generator>
> >       <map:generator name="exception"
> >                   src="org.apache.cocoon.generation.ParseExceptionGenerator"/>
> >                   
> >     </map:generators>
> 
> And why are these already in sitemap.xmap but commented out?

Don't know. Does 'svn log' or 'svn blame' help?
They are obviously not used, so i would just remove them.

-David

> > <!--
> >       <map:generator name="html"      src="org.apache.cocoon.generation.HTMLGenerator">
> >         <jtidy-config>jtidy.properties</jtidy-config>
> >       </map:generator>
> >       <map:generator name="directory" src="org.apache.cocoon.generation.DirectoryGenerator" />
> >       -->
> 
> 
> --
> Ferdinand Soethe

Re: Q: Placement of generators (FIXME in forrest.xmap )

[Ross Gardler <rg...@apache.org>]

Ferdinand Soethe wrote:
> Any reason not to move these to sitemap.xmap?

Not that I can see. I think they were originally put into the 
sub-sitemaps so that we know what is used where. However, they have not 
been correctly maintained and it is confusing now.

As more and more stuff is moved out to plugins the number of components 
in the core sitemaps will be reduced in the way originally intended.

> And why are these already in sitemap.xmap but commented out?

Just guessing - somebody noticed they weren't used and commented them 
out in order to indicate this. They probably chose not to remove them 
incase there was a reason for them to be present. I can't remember when 
this was done, I guess some time ago so it is probably safe to remove 
them (although some will be put back because of your other question above).

Anyway, since nobody has said anything on this just go ahead and do what 
you think is necessary to make the sitemaps clearer.

Ross