[jira] [Commented] (SPARK-37425) Inline type hints for python/pyspark/mllib/recommendation.py

["Amir Kadivar (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-37425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467778#comment-17467778 ] 

Amir Kadivar commented on SPARK-37425:
--------------------------------------

[~zero323] First time spark contributor here.

I've worked on this as a starting point to help with other issues in SPARK-37425 (mllib type hints). I can submit a PR but my understanding as per [this comment|https://github.com/apache/spark/pull/34680#issuecomment-975397090] of yours is that you'd like to wait for core type hints (ie SPARK-37094) to be done first, which makes sense!

Also, if I understand correctly everything in SPARK-37094 (core type hints) is either resolved or in progress. Most notable remaining dependency that bleeds everywhere in mllib is rdd.py and it seems like [~byronhsu] is working on it in SPARK-37154.

All this seems reasonable to me, just wanted to confirm the plan and voice that I'll have a PR for this ticket pending on [~byronhsu]'s work on rdd.py

> Inline type hints for python/pyspark/mllib/recommendation.py
> ------------------------------------------------------------
>
>                 Key: SPARK-37425
>                 URL: https://issues.apache.org/jira/browse/SPARK-37425
>             Project: Spark
>          Issue Type: Sub-task
>          Components: MLlib, PySpark
>    Affects Versions: 3.3.0
>            Reporter: Maciej Szymkiewicz
>            Priority: Major
>
> Inline type hints from python/pyspark/mlib/recommendation.pyi to python/pyspark/mllib/recommendation.py



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org