[GitHub] [geode] davebarnes97 commented on pull request #5600: GEODE-8202: Two-step serial gw sender threads start

[GitBox <gi...@apache.org>]

davebarnes97 commented on pull request #5600:
URL: https://github.com/apache/geode/pull/5600#issuecomment-704612068


   @alb3rtobr Thank you for your contribution. I read the documentation you provided in `geode-docs/tools_modules/gfsh/command-pages/create.html.md.erb` and I'm working on a few grammatical changes. But before I submit them, I would like to better understand the name of the property you propose, `--receivers-sharing-ip-and-port`, and the part of the explanation that says "Sets whether or not the receivers are sharing the same ip and port."
   If I understand the RFC correctly, the general context is an environment in which multiple receivers specify a duplicate ip:port combination (not exactly 'sharing'), and the purpose of the property is to say to gfsh, "When you create this sender, be sure that all of its dispatcher threads connect to the same receiver."
   Also, it sounds like this option would work (though it would be unnecessary) if there was only one receiver up and running.
   So I think this property needs a more precise name. Something like `--enforce-all-threads-same-receiver` or something like that.
   [This became very long. I've contributed it as a comment on the RFC.]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org