You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/16 04:32:31 UTC

[GitHub] [spark] yabola opened a new pull request, #39087: [SPARK-41365][UI][3.3-backport] Stages UI page fails to load for proxy in specific yarn environment

yabola opened a new pull request, #39087:
URL: https://github.com/apache/spark/pull/39087

   backport https://github.com/apache/spark/pull/38882
   
   ### What changes were proposed in this pull request?
   Stages UI page fails to load for proxy in some specific yarn environment.
   
   ### Why are the changes needed?
   My environment CDH 5.8 , click to enter the spark UI from the yarn Resource Manager page
   when visit the stage URI, it fails to load,  URI is
   http://<yarn-url>:8088/proxy/application_1669877165233_0021/stages/stage/?id=0&attempt=0 
   
   The issue is similar to, the final phenomenon of the issue is the same, because the parameter encode twice
   [SPARK-32467](https://issues.apache.org/jira/browse/SPARK-32467)
   [SPARK-33611](https://issues.apache.org/jira/browse/SPARK-33611)
   
   The two issues solve two scenarios to avoid encode twice:
   1. https redirect proxy
   2. set reverse proxy enabled (spark.ui.reverseProxy)  in Nginx 
   
   But if encode twice due to other reasons, such as this issue (yarn proxy), it will also fail when visit stage page.
   It is better to decode parameter twice here. 
   Just like fix here [SPARK-12708](https://issues.apache.org/jira/browse/SPARK-12708) [codes](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/ui/UIUtils.scala#L626)
   
   ### Does this PR introduce any user-facing change?
   No
   
   ### How was this patch tested?
   new added UT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #39087: [SPARK-41365][UI][3.3] Stages UI page fails to load for proxy in specific yarn environment

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #39087: [SPARK-41365][UI][3.3] Stages UI page fails to load for proxy in specific yarn environment
URL: https://github.com/apache/spark/pull/39087


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yabola commented on pull request #39087: [SPARK-41365][UI][3.3] Stages UI page fails to load for proxy in specific yarn environment

Posted by GitBox <gi...@apache.org>.
yabola commented on PR #39087:
URL: https://github.com/apache/spark/pull/39087#issuecomment-1355977687

   @dongjoon-hyun Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #39087: [SPARK-41365][UI][Backport] Stages UI page fails to load for proxy in specific yarn environment

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #39087:
URL: https://github.com/apache/spark/pull/39087#issuecomment-1354203620

   `[SPARK-41365][UI][3.3] `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yabola commented on pull request #39087: [SPARK-41365][UI][3.3] Stages UI page fails to load for proxy in specific yarn environment

Posted by GitBox <gi...@apache.org>.
yabola commented on PR #39087:
URL: https://github.com/apache/spark/pull/39087#issuecomment-1354458268

   It seems that Jenkins is stuck...
   ![image](https://user-images.githubusercontent.com/31469905/208068460-e20520cd-6d40-43e6-a8c4-9a3e53cf3434.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yabola commented on pull request #39087: [SPARK-41365][UI][3.3] Stages UI page fails to load for proxy in specific yarn environment

Posted by GitBox <gi...@apache.org>.
yabola commented on PR #39087:
URL: https://github.com/apache/spark/pull/39087#issuecomment-1354458695

   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #39087: [SPARK-41365][UI][3.3] Stages UI page fails to load for proxy in specific yarn environment

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #39087:
URL: https://github.com/apache/spark/pull/39087#issuecomment-1355492859

   I added you to the Apache Spark contributor group and assign SPARK-41365 to you.
   Welcome to the Apache Spark community, @yabola .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org