You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Weiwei Yang (JIRA)" <ji...@apache.org> on 2017/04/28 02:27:04 UTC

[jira] [Comment Edited] (HDFS-11675) Ozone: SCM CLI: Implement delete container command

    [ https://issues.apache.org/jira/browse/HDFS-11675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988071#comment-15988071 ] 

Weiwei Yang edited comment on HDFS-11675 at 4/28/17 2:26 AM:
-------------------------------------------------------------

Hi [~anu]

I prefer to keep it under {{container}} command, semantically it is a container operation. To delete a command from commandline with this patch, it works like following

# User types command {{hdfs scm -container -del <containerName>}} from commandline
# {{DeleteContainerHandler}} looks up the pipeline where this container lives by calling {{ScmClient#getContainer}}
# {{DeleteContainerHandler}} deletes the container from the nodes in the pipeline by calling {{ScmClient#deleteContainer}}

we don't support to specify a node right now, we query SCM for the nodes. So I don't see how it helps to move this to {{node}} command. We just need to improve the deletion logic in HDFS-11716, that will have no modification to CLI code anyway. Does that make sense to you?


was (Author: cheersyang):
Hi [~anu]

I prefer to keep it under {{container}} command, semantically it is a container operation. To delete a command from commandline with this patch, it works like following

# User types command {{hdfs scm -container -del <containerName>}} from commandline
# {{DeleteContainerHandler}} looks up the pipeline where this container lives by calling {{ScmClient#getContainer}}
# {{DeleteContainerHandler}} deletes the container from the nodes in the pipeline by calling {{ScmClient#deleteContainer}}

we don't support to specify a node right now, we query SCM for the nodes. So I don't see how it helps to move this to {{node}} command. We just need to improve the deletion logic in HDFS-11716, that will have no modification to CLI code anyway.

> Ozone: SCM CLI: Implement delete container command
> --------------------------------------------------
>
>                 Key: HDFS-11675
>                 URL: https://issues.apache.org/jira/browse/HDFS-11675
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>              Labels: command-line
>         Attachments: HDFS-11675-HDFS-7240.001.patch, HDFS-11675-HDFS-7240.002.patch, HDFS-11675-HDFS-7240.003.patch, HDFS-11675-HDFS-7240.004.patch
>
>
> Implement delete container
> {code}
> hdfs scm -container del <container name> -f
> {code}
> Deletes a container if it is empty. The -f options can be used to force a delete of a non-empty container. If container name specified not exist, prints a clear error message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org