[GitHub] [spark] cloud-fan commented on a diff in pull request #38464: [SPARK-32628][SQL] Use bloom filter to improve dynamic partition pruning

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #38464:
URL: https://github.com/apache/spark/pull/38464#discussion_r1023678622


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/PlanAdaptiveDynamicPruningFilters.scala:
##########
@@ -65,7 +70,7 @@ case class PlanAdaptiveDynamicPruningFilters(
           DynamicPruningExpression(InSubqueryExec(value, broadcastValues, exprId))
         } else if (onlyInBroadcast) {
           DynamicPruningExpression(Literal.TrueLiteral)
-        } else {
+        } else if (canBroadcastBySize(buildPlan, conf)) {

Review Comment:
   this can be over estimated. The final plan has an `Aggregate` which may dramatically reduce the data size.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org