[GitHub] [tinkerpop] spmallette commented on a change in pull request #1224: TINKERPOP-1733 Support g.E().properties().hasKey('xx') & hasValue('xx')

[GitBox <gi...@apache.org>]

spmallette commented on a change in pull request #1224: TINKERPOP-1733 Support g.E().properties().hasKey('xx') & hasValue('xx')
URL: https://github.com/apache/tinkerpop/pull/1224#discussion_r350697093
 
 

 ##########
 File path: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/star/StarGraph.java
 ##########
 @@ -869,6 +870,32 @@ public Vertex inVertex() {
         }
     }
 
+    public final class StarEdgeId {
 
 Review comment:
   This is a bit worrisome. Does this mean that if a user accesses an edge identifier in OLAP they won't get back their edge id, they will instead get a `StarEdgeId`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services