You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ibatis.apache.org by Ate Douma <at...@douma.nu> on 2004/12/23 11:33:01 UTC
Is JPetstore (becoming) available under ASF license too?
I send a message to Clinton Begin 10 days ago if it would be allowed
to use JPetstore as an example Portlet Application for Jetspeed-2.
Because I didn't receive any response yet, and I thereafter got the
impression you might also be moving the JPetstore sources into the
incubator, I present my request again through this channel.
I'll repeat much of my previous message below, although a bit
rephrased in the expectancy of an ASF for JPetstore.
Here it goes:
I'm one of the developers of the Apache Jetspeed-2 portal.
For the portal, we already have created a few small demo portlet applications,
but it would be nice to also supply a more "showcase" kind of application.
I think your JPetstore would be a fine example.
I don't know how much you about Jetspeed-2 (http://portals.apache.org/jetspeed-2)
but one type of components we deliver with it are bridges for web-framework like
Struts, MyFaces, PHP, Perl, Velocity etc.
I'm the developer of the Struts Bridge which allows Struts web applications to be
run as JSR-168 compliant portlets. If a Struts application is properly setup
(using true MVC model, correct use of the struts taglibs etc.) this is quite easy
to do.
So, I started out to make the JPetstore Portlet compliant. For this, I needed to
correct several aspects in the jsp files (like not directly submitting <img...>
tags but using <html:img... tags instead) and a few small changes to the struts-config
file. Also, I had to modify the Product table and mapping to separate the image name
from the description (and remove the markup) because the stored markup doesn't
work from within a Portlet.
After a few hours, I now have the JPetstore 100% working as a portlet (note: there were
a few quicks related to the usage of com.ibatis.struts.ActionContext.setSimpleMessage
and .addSimpleError methods, but I've transparently covered that now too).
Now that I have proven this was easy to do and is working, I would like to ask you
if you would allow my version of the JPetstore to be included as sample portlet
in Jetspeed-2? Not only is it a nice example, it also is a perfect showcase how a
good setup Struts application can be transformed into a portlet application without
too many changes.
Note: I kept the cleaned up version of JPetstore *before* I transformed it into a portlet
separate. That is still a "native" web application, just more "strutsified". If you
are interested, I can supply that version. If you agree to this request, it might be
even nicer if you would accept those changes to JPetstore too, so that anyone interested
can clearly compare the changes I made to transform it into a Portlet Application (almost
none in that case).
Back to embedding the portlet version into Jetspeed-2. If you agree, I would like to
check my version in in the cvs repository of Jetspeed-2. But, because that is an Apache
repository, it will require a Apache license for it, and hence this request.
If you agree, will it be allowed for me to do so right away, or need I wait until you have
checked in the JPetstore under incubator (if you are going to do so) and base my version on that?
One last question about iBATIS itself. Jetspeed-2 is completely build using maven.
Dependencies are retrieved through public remote maven repositories.
Because I couldn't find iBATIS libraries anywhere (e.g. www.ibiblio.org/maven) I put them
myself in my local repository.
Do you have plans to make the iBATIS libraries available through ibiblio?
Regards,
Ate Douma
Re: Code Transfer (was Re: Is JPetstore ...)
Posted by Ted Husted <hu...@apache.org>.
Cool.
In the US, the appropriate legal term would be "assign" the copyright to the ASF.
But, tomato, tomato. :)
On Thu, 30 Dec 2004 10:54:25 -0700, Clinton Begin wrote:
>�Agreed. �My intention was not to hold copyright or maintain any
>�restrictions, it was simply to ensure that we comply with our own
>�license. �:-)
>
>�That said, I suppose the CLA does cover this, so I basically
>�release my "copyright" to Apache.
>
>�I'll change all of the copyright statements in the code.
>
>�Cheers,
>�Clinton
>
>
>�On Wed, 29 Dec 2004 20:03:56 -0500, Ted Husted <hu...@apache.org>
>�wrote:
>
>>�In general, copyright is assigned to the ASF when we make the
>>�commits.
>>
>>�That's what the CLAs are about
>>�[http://apache.org/licenses/icla.txt].
>>
>>�unless we specifically mark something "not a contribution."
>>
>>�When we roll the repositories over, it wouldn't hurt if Clinton
>>�and Gilles filed a software grant, to cover the bulk transfer.
>>
>>�[http://apache.org/licenses/software-grant.txt]
>>
>>�But, the CLAs would cover that too.
>>
>>�Whether you wanted to continue carrying a copyright on source
>>�code when it's transferred is up to you. If you did, then, yes,
>>�the NOTICES file is the place to put it.
>>
>>�[http://apache.org/licenses/example-NOTICE.txt]
>>
>>�Of course, given the license, there aren't many advantages to
>>�claiming a copyright :) -- And one of the advantages of being at
>>�the ASF is that we can keep our names, and the attendant
>>�liability issues, out of it.
>>
>>�I believe the only reason there is even a copyright is so that we
>>�have the leverage to apply the license. And the role of the
>>�license seems mainly to assure people where the code came from,
>>�and that it is not encumbered by restrictions imposed by some
>>�other licenses.
>>
>>�-Ted.
>>
>>�On Fri, 24 Dec 2004 14:20:09 -0700, Clinton Begin wrote:
>>
>>>�Actually, that raises a question of my own....when we do
>>>�transfer iBATIS and JPetStore to Apache under a different
>>>�copyright name, I suppose that to comply with the existing
>>>�license, we would need to include the copyright banner with my
>>>�name in some text file in 3rd party licenses....?
>>>
>>>�Just a thought.
>>>
>>>�Clinton
>>>
>>>
>>>�On Fri, 24 Dec 2004 14:18:50 -0700, Clinton Begin
>>>�<cl...@gmail.com>�wrote:
>>>
>>>>>�Great. I wasn't sure because I used the 4.0.5 source which
>>>>>�still contains a license.txt claiming only you to be the
>>>>>�license holder...
>>>>>
>>>>>
>>>>�I don't see how that matters at all. �I don't hold the
>>>>�license, I hold the copyright. �Basically, the way the
>>>>�license works (whether it's my name on the copyright, or
>>>>�Apache), you can use it however you like. The only thing you
>>>>�cannot do is claim that it's yours or otherwise not "mine" or
>>>>�eventually "Apache's".
>>>>
>>>>�Don't let that stop you from using it.
>>>>
>>>>�Cheers,
>>>>�Clinton
>>>>
>>>>
>>>>�On Fri, 24 Dec 2004 21:16:13 +0100, Ate Douma <at...@douma.nu>
>>>>�wrote:
>>>>
>>>>
>>>>>�Clinton Begin wrote:
>>>>>>�Hi Ate,
>>>>>>
>>>>>>�Sorry for the delay. �To answer your questions:
>>>>>>
>>>>>>�2) Yes, you are more than welcome to include JPetStore as
>>>>>>�a sample application with Jetspeed-2. �It is licensed
>>>>>>�under the Apache license just like the rest of iBATIS.
>>>>>>
>>>>>�Great. I wasn't sure because I used the 4.0.5 source which
>>>>>�still contains a license.txt claiming only you to be the
>>>>>�license holder... Have you already moved the source to an
>>>>>�apache repository and if so, is it already available as
>>>>>�such?
>>>>>
>>>>>
>>>>>>�3) I am interested in the modifications you've made to
>>>>>>�the JSPs. However, JPetStore will eventually undergo a
>>>>>>�major rewrite to correct a lot of the "historical scars"
>>>>>>�and to make it a better example application. �I'd prefer
>>>>>>�to wait for that before making any broad changes.
>>>>>>
>>>>>�As I said, I can provide you will all the changes I've
>>>>>�made. Just let me know who/where I should mail it to. I
>>>>>�have the below list of changes in different sets (1-3
>>>>>�ready) so you could use all, none or just a few :-)
>>>>>
>>>>>�You should know my intention is to use the JPetstore as an
>>>>>�example/tutorial how to migrate a Struts web application to
>>>>>�a portlet application. For that purpose, I changed the
>>>>>�original sources in 5 iterations:
>>>>>
>>>>>�1) Reformat the html and jsp sources to get a readable
>>>>>�indentation and nesting of tags, and furthermore clean up a
>>>>>�few superfluous constructions.
>>>>>�To be able to compare the changes I make in each step,
>>>>>�having the source in comparable structure helps a lot! No
>>>>>�functional changes so far.
>>>>>�2) Split the product.description values in an imageName and
>>>>>�description. The product.description contained both the
>>>>>�html markup as well as the description of a pet image. I've
>>>>>�changed the Item.jsp to render the image now using these
>>>>>�two distinct properties.
>>>>>�The reason for this action is that for a JSR-168 Portlet
>>>>>�Application the rendering of an image url should be handled
>>>>>�differently. This is only a technical change. 3) Put a ASF
>>>>>�license header in all source files.
>>>>>�As I need to check the sources into the Jetspeed-2 cvs/svn
>>>>>�repository this one is required. I guess the same applies
>>>>>�for iBATIS when you check in the sources in the apache svn
>>>>>�repository. No technical or functional changes. 4) Further
>>>>>�"strutified" the application.
>>>>>�This concerns using more struts tags where appropriate,
>>>>>�like replacing <form with <html:form, <a with <html:link,
>>>>>�<input type="image with <html:image and <img with <html:img
>>>>>�tags. This also required me to change the index.html and
>>>>>�help.html into jsp files. No functional changes.
>>>>>�5) The final step in migrating to a Portlet Application.
>>>>>�This involves a few changes to struts-config.xml like
>>>>>�forwarding to actions instead of jsp files directly and
>>>>>�plugging in my own StrutsPortletRequestProcessor.
>>>>>�Furthermore, using relative url paths isn't always working
>>>>>�in a portal environment because the portlet specification
>>>>>�doesn't say how portals should provide a portlet with a
>>>>>�proper context path during rendering. For that, I needed to
>>>>>�modify all image references to context path relative. The
>>>>>�Struts Portlet Bridge I've developed provides adapted
>>>>>�versions of a few Struts html tags. To use these
>>>>>�transparently, I map a different tld in web.xml for the
>>>>>�struts- html tld.
>>>>>�I'm currently working on allowing the Bridge to be used in
>>>>>�a web application context too. When that is complete the
>>>>>�same jpetstore.war can be deployed as portlet application
>>>>>�or as web application without any needed change!
>>>>>
>>>>>�The changes i needed to make between iteration 4 and 5 is
>>>>>�what I'm really after. As I said, I'm still working on
>>>>>�iteration 5 (and maybe some more on 4). When I have
>>>>>�finished that (probably somewhere next week) I will check
>>>>>�in the sources for iteration 3, 4 and 5 (the latter being
>>>>>�used as example portlet in Jetspeed-2) in the Jetspeed-2
>>>>>�svn repository. I'll let you know when I've done so.
>>>>>
>>>>>
>>>>>>�4) I have no personal plans to make iBATIS available via
>>>>>>�ibiblio, but I am not opposed to the idea.
>>>>>>
>>>>>�Would be nice when that happens. Will make it much easier
>>>>>�for maven based projects to use iBATIS.
>>>>>
>>>>>�Regards,
>>>>>
>>>>>�Ate
>>>>>
>>>>>>
>>>>>>�Cheers,
>>>>>>�Clinton
Re: Code Transfer (was Re: Is JPetstore ...)
Posted by Clinton Begin <cl...@gmail.com>.
Agreed. My intention was not to hold copyright or maintain any
restrictions, it was simply to ensure that we comply with our own
license. :-)
That said, I suppose the CLA does cover this, so I basically release
my "copyright" to Apache.
I'll change all of the copyright statements in the code.
Cheers,
Clinton
On Wed, 29 Dec 2004 20:03:56 -0500, Ted Husted <hu...@apache.org> wrote:
> In general, copyright is assigned to the ASF when we make the commits.
>
> That's what the CLAs are about [http://apache.org/licenses/icla.txt].
>
> unless we specifically mark something "not a contribution."
>
> When we roll the repositories over, it wouldn't hurt if Clinton and Gilles filed a software grant, to cover the bulk transfer.
>
> [http://apache.org/licenses/software-grant.txt]
>
> But, the CLAs would cover that too.
>
> Whether you wanted to continue carrying a copyright on source code when it's transferred is up to you. If you did, then, yes, the NOTICES file is the place to put it.
>
> [http://apache.org/licenses/example-NOTICE.txt]
>
> Of course, given the license, there aren't many advantages to claiming a copyright :) -- And one of the advantages of being at the ASF is that we can keep our names, and the attendant liability issues, out of it.
>
> I believe the only reason there is even a copyright is so that we have the leverage to apply the license. And the role of the license seems mainly to assure people where the code came from, and that it is not encumbered by restrictions imposed by some other licenses.
>
> -Ted.
>
> On Fri, 24 Dec 2004 14:20:09 -0700, Clinton Begin wrote:
> > Actually, that raises a question of my own....when we do transfer
> > iBATIS and JPetStore to Apache under a different copyright name, I
> > suppose that to comply with the existing license, we would need to
> > include the copyright banner with my name in some text file in 3rd
> > party licenses....?
> >
> > Just a thought.
> >
> > Clinton
> >
> >
> > On Fri, 24 Dec 2004 14:18:50 -0700, Clinton Begin
> > <cl...@gmail.com> wrote:
> >>> Great. I wasn't sure because I used the 4.0.5 source which
> >>> still contains a license.txt claiming only you to be the
> >>> license holder...
> >>>
> >>
> >> I don't see how that matters at all. I don't hold the license, I
> >> hold the copyright. Basically, the way the license works
> >> (whether it's my name on the copyright, or Apache), you can use
> >> it however you like. The only thing you cannot do is claim that
> >> it's yours or otherwise not "mine" or eventually "Apache's".
> >>
> >> Don't let that stop you from using it.
> >>
> >> Cheers,
> >> Clinton
> >>
> >>
> >> On Fri, 24 Dec 2004 21:16:13 +0100, Ate Douma <at...@douma.nu>
> >> wrote:
> >>
> >>>
> >>> Clinton Begin wrote:
> >>>> Hi Ate,
> >>>>
> >>>> Sorry for the delay. To answer your questions:
> >>>>
> >>>> 2) Yes, you are more than welcome to include JPetStore as a
> >>>> sample application with Jetspeed-2. It is licensed under the
> >>>> Apache license just like the rest of iBATIS.
> >>>>
> >>> Great. I wasn't sure because I used the 4.0.5 source which
> >>> still contains a license.txt claiming only you to be the
> >>> license holder... Have you already moved the source to an
> >>> apache repository and if so, is it already available as such?
> >>>
> >>>
> >>>> 3) I am interested in the modifications you've made to the
> >>>> JSPs. However, JPetStore will eventually undergo a major
> >>>> rewrite to correct a lot of the "historical scars" and to
> >>>> make it a better example application. I'd prefer to wait for
> >>>> that before making any broad changes.
> >>>>
> >>> As I said, I can provide you will all the changes I've made.
> >>> Just let me know who/where I should mail it to. I have the
> >>> below list of changes in different sets (1-3 ready) so you
> >>> could use all, none or just a few :-)
> >>>
> >>> You should know my intention is to use the JPetstore as an
> >>> example/tutorial how to migrate a Struts web application to a
> >>> portlet application. For that purpose, I changed the original
> >>> sources in 5 iterations:
> >>>
> >>> 1) Reformat the html and jsp sources to get a readable
> >>> indentation and nesting of tags, and furthermore clean up a few
> >>> superfluous constructions.
> >>> To be able to compare the changes I make in each step, having
> >>> the source in comparable structure helps a lot! No functional
> >>> changes so far.
> >>> 2) Split the product.description values in an imageName and
> >>> description. The product.description contained both the html
> >>> markup as well as the description of a pet image.
> >>> I've changed the Item.jsp to render the image now using these
> >>> two distinct properties.
> >>> The reason for this action is that for a JSR-168 Portlet
> >>> Application the rendering of an image url should be handled
> >>> differently. This is only a technical change. 3) Put a ASF
> >>> license header in all source files.
> >>> As I need to check the sources into the Jetspeed-2 cvs/svn
> >>> repository this one is required. I guess the same applies for
> >>> iBATIS when you check in the sources in the apache svn
> >>> repository. No technical or functional changes. 4) Further
> >>> "strutified" the application.
> >>> This concerns using more struts tags where appropriate, like
> >>> replacing <form with <html:form, <a with <html:link, <input
> >>> type="image with <html:image and <img with <html:img tags.
> >>> This also required me to change the index.html and help.html
> >>> into jsp files. No functional changes.
> >>> 5) The final step in migrating to a Portlet Application. This
> >>> involves a few changes to struts-config.xml like forwarding to
> >>> actions instead of jsp files directly and plugging in my own
> >>> StrutsPortletRequestProcessor. Furthermore, using relative url
> >>> paths isn't always working in a portal environment because the
> >>> portlet specification doesn't say how portals should provide a
> >>> portlet with a proper context path during rendering. For that,
> >>> I needed to modify all image references to context path
> >>> relative. The Struts Portlet Bridge I've developed provides
> >>> adapted versions of a few Struts html tags. To use these
> >>> transparently, I map a different tld in web.xml for the struts-
> >>> html tld.
> >>> I'm currently working on allowing the Bridge to be used in a
> >>> web application context too. When that is complete the same
> >>> jpetstore.war can be deployed as portlet application or as web
> >>> application without any needed change!
> >>>
> >>> The changes i needed to make between iteration 4 and 5 is what
> >>> I'm really after. As I said, I'm still working on iteration 5
> >>> (and maybe some more on 4). When I have finished that (probably
> >>> somewhere next week) I will check in the sources for iteration
> >>> 3, 4 and 5 (the latter being used as example portlet in
> >>> Jetspeed-2) in the Jetspeed-2 svn repository. I'll let you know
> >>> when I've done so.
> >>>
> >>>
> >>>> 4) I have no personal plans to make iBATIS available via
> >>>> ibiblio, but I am not opposed to the idea.
> >>>>
> >>> Would be nice when that happens. Will make it much easier for
> >>> maven based projects to use iBATIS.
> >>>
> >>> Regards,
> >>>
> >>> Ate
> >>>
> >>>>
> >>>> Cheers,
> >>>> Clinton
>
>
Code Transfer (was Re: Is JPetstore ...)
Posted by Ted Husted <hu...@apache.org>.
In general, copyright is assigned to the ASF when we make the commits.
That's what the CLAs are about [http://apache.org/licenses/icla.txt].
unless we specifically mark something "not a contribution."
When we roll the repositories over, it wouldn't hurt if Clinton and Gilles filed a software grant, to cover the bulk transfer.
[http://apache.org/licenses/software-grant.txt]
But, the CLAs would cover that too.
Whether you wanted to continue carrying a copyright on source code when it's transferred is up to you. If you did, then, yes, the NOTICES file is the place to put it.
[http://apache.org/licenses/example-NOTICE.txt]
Of course, given the license, there aren't many advantages to claiming a copyright :) -- And one of the advantages of being at the ASF is that we can keep our names, and the attendant liability issues, out of it.
I believe the only reason there is even a copyright is so that we have the leverage to apply the license. And the role of the license seems mainly to assure people where the code came from, and that it is not encumbered by restrictions imposed by some other licenses.
-Ted.
On Fri, 24 Dec 2004 14:20:09 -0700, Clinton Begin wrote:
>�Actually, that raises a question of my own....when we do transfer
>�iBATIS and JPetStore to Apache under a different copyright name, I
>�suppose that to comply with the existing license, we would need to
>�include the copyright banner with my name in some text file in 3rd
>�party licenses....?
>
>�Just a thought.
>
>�Clinton
>
>
>�On Fri, 24 Dec 2004 14:18:50 -0700, Clinton Begin
>�<cl...@gmail.com>�wrote:
>>>�Great. I wasn't sure because I used the 4.0.5 source which
>>>�still contains a license.txt claiming only you to be the
>>>�license holder...
>>>
>>
>>�I don't see how that matters at all. �I don't hold the license, I
>>�hold the copyright. �Basically, the way the license works
>>�(whether it's my name on the copyright, or Apache), you can use
>>�it however you like. The only thing you cannot do is claim that
>>�it's yours or otherwise not "mine" or eventually "Apache's".
>>
>>�Don't let that stop you from using it.
>>
>>�Cheers,
>>�Clinton
>>
>>
>>�On Fri, 24 Dec 2004 21:16:13 +0100, Ate Douma <at...@douma.nu>
>>�wrote:
>>
>>>
>>>�Clinton Begin wrote:
>>>>�Hi Ate,
>>>>
>>>>�Sorry for the delay. �To answer your questions:
>>>>
>>>>�2) Yes, you are more than welcome to include JPetStore as a
>>>>�sample application with Jetspeed-2. �It is licensed under the
>>>>�Apache license just like the rest of iBATIS.
>>>>
>>>�Great. I wasn't sure because I used the 4.0.5 source which
>>>�still contains a license.txt claiming only you to be the
>>>�license holder... Have you already moved the source to an
>>>�apache repository and if so, is it already available as such?
>>>
>>>
>>>>�3) I am interested in the modifications you've made to the
>>>>�JSPs. However, JPetStore will eventually undergo a major
>>>>�rewrite to correct a lot of the "historical scars" and to
>>>>�make it a better example application. �I'd prefer to wait for
>>>>�that before making any broad changes.
>>>>
>>>�As I said, I can provide you will all the changes I've made.
>>>�Just let me know who/where I should mail it to. I have the
>>>�below list of changes in different sets (1-3 ready) so you
>>>�could use all, none or just a few :-)
>>>
>>>�You should know my intention is to use the JPetstore as an
>>>�example/tutorial how to migrate a Struts web application to a
>>>�portlet application. For that purpose, I changed the original
>>>�sources in 5 iterations:
>>>
>>>�1) Reformat the html and jsp sources to get a readable
>>>�indentation and nesting of tags, and furthermore clean up a few
>>>�superfluous constructions.
>>>�To be able to compare the changes I make in each step, having
>>>�the source in comparable structure helps a lot! No functional
>>>�changes so far.
>>>�2) Split the product.description values in an imageName and
>>>�description. The product.description contained both the html
>>>�markup as well as the description of a pet image.
>>>�I've changed the Item.jsp to render the image now using these
>>>�two distinct properties.
>>>�The reason for this action is that for a JSR-168 Portlet
>>>�Application the rendering of an image url should be handled
>>>�differently. This is only a technical change. 3) Put a ASF
>>>�license header in all source files.
>>>�As I need to check the sources into the Jetspeed-2 cvs/svn
>>>�repository this one is required. I guess the same applies for
>>>�iBATIS when you check in the sources in the apache svn
>>>�repository. No technical or functional changes. 4) Further
>>>�"strutified" the application.
>>>�This concerns using more struts tags where appropriate, like
>>>�replacing <form with <html:form, <a with <html:link, <input
>>>�type="image with <html:image and <img with <html:img tags.
>>>�This also required me to change the index.html and help.html
>>>�into jsp files. No functional changes.
>>>�5) The final step in migrating to a Portlet Application. This
>>>�involves a few changes to struts-config.xml like forwarding to
>>>�actions instead of jsp files directly and plugging in my own
>>>�StrutsPortletRequestProcessor. Furthermore, using relative url
>>>�paths isn't always working in a portal environment because the
>>>�portlet specification doesn't say how portals should provide a
>>>�portlet with a proper context path during rendering. For that,
>>>�I needed to modify all image references to context path
>>>�relative. The Struts Portlet Bridge I've developed provides
>>>�adapted versions of a few Struts html tags. To use these
>>>�transparently, I map a different tld in web.xml for the struts-
>>>�html tld.
>>>�I'm currently working on allowing the Bridge to be used in a
>>>�web application context too. When that is complete the same
>>>�jpetstore.war can be deployed as portlet application or as web
>>>�application without any needed change!
>>>
>>>�The changes i needed to make between iteration 4 and 5 is what
>>>�I'm really after. As I said, I'm still working on iteration 5
>>>�(and maybe some more on 4). When I have finished that (probably
>>>�somewhere next week) I will check in the sources for iteration
>>>�3, 4 and 5 (the latter being used as example portlet in
>>>�Jetspeed-2) in the Jetspeed-2 svn repository. I'll let you know
>>>�when I've done so.
>>>
>>>
>>>>�4) I have no personal plans to make iBATIS available via
>>>>�ibiblio, but I am not opposed to the idea.
>>>>
>>>�Would be nice when that happens. Will make it much easier for
>>>�maven based projects to use iBATIS.
>>>
>>>�Regards,
>>>
>>>�Ate
>>>
>>>>
>>>>�Cheers,
>>>>�Clinton
Re: Is JPetstore (becoming) available under ASF license too?
Posted by Clinton Begin <cl...@gmail.com>.
Actually, that raises a question of my own....when we do transfer
iBATIS and JPetStore to Apache under a different copyright name, I
suppose that to comply with the existing license, we would need to
include the copyright banner with my name in some text file in 3rd
party licenses....?
Just a thought.
Clinton
On Fri, 24 Dec 2004 14:18:50 -0700, Clinton Begin
<cl...@gmail.com> wrote:
> > Great. I wasn't sure because I used the 4.0.5 source which still
> > contains a license.txt claiming only you to be the license holder...
>
> I don't see how that matters at all. I don't hold the license, I hold
> the copyright. Basically, the way the license works (whether it's my
> name on the copyright, or Apache), you can use it however you like.
> The only thing you cannot do is claim that it's yours or otherwise not
> "mine" or eventually "Apache's".
>
> Don't let that stop you from using it.
>
> Cheers,
> Clinton
>
>
> On Fri, 24 Dec 2004 21:16:13 +0100, Ate Douma <at...@douma.nu> wrote:
> >
> >
> > Clinton Begin wrote:
> > > Hi Ate,
> > >
> > > Sorry for the delay. To answer your questions:
> > >
> > > 2) Yes, you are more than welcome to include JPetStore as a sample
> > > application with Jetspeed-2. It is licensed under the Apache license
> > > just like the rest of iBATIS.
> > Great. I wasn't sure because I used the 4.0.5 source which still
> > contains a license.txt claiming only you to be the license holder...
> > Have you already moved the source to an apache repository and if so,
> > is it already available as such?
> >
> > >
> > > 3) I am interested in the modifications you've made to the JSPs.
> > > However, JPetStore will eventually undergo a major rewrite to correct
> > > a lot of the "historical scars" and to make it a better example
> > > application. I'd prefer to wait for that before making any broad
> > > changes.
> > As I said, I can provide you will all the changes I've made. Just let
> > me know who/where I should mail it to. I have the below list of changes
> > in different sets (1-3 ready) so you could use all, none or just a few :-)
> >
> > You should know my intention is to use the JPetstore as an example/tutorial
> > how to migrate a Struts web application to a portlet application.
> > For that purpose, I changed the original sources in 5 iterations:
> >
> > 1) Reformat the html and jsp sources to get a readable indentation
> > and nesting of tags, and furthermore clean up a few superfluous
> > constructions.
> > To be able to compare the changes I make in each step, having
> > the source in comparable structure helps a lot!
> > No functional changes so far.
> > 2) Split the product.description values in an imageName and description.
> > The product.description contained both the html markup as well as
> > the description of a pet image.
> > I've changed the Item.jsp to render the image now using these
> > two distinct properties.
> > The reason for this action is that for a JSR-168 Portlet Application
> > the rendering of an image url should be handled differently.
> > This is only a technical change.
> > 3) Put a ASF license header in all source files.
> > As I need to check the sources into the Jetspeed-2 cvs/svn repository
> > this one is required. I guess the same applies for iBATIS when you
> > check in the sources in the apache svn repository.
> > No technical or functional changes.
> > 4) Further "strutified" the application.
> > This concerns using more struts tags where appropriate, like replacing
> > <form with <html:form, <a with <html:link, <input type="image with
> > <html:image and <img with <html:img tags.
> > This also required me to change the index.html and help.html into jsp
> > files.
> > No functional changes.
> > 5) The final step in migrating to a Portlet Application. This involves
> > a few changes to struts-config.xml like forwarding to actions instead of
> > jsp files directly and plugging in my own StrutsPortletRequestProcessor.
> > Furthermore, using relative url paths isn't always working in a portal
> > environment because the portlet specification doesn't say how portals
> > should provide a portlet with a proper context path during rendering.
> > For that, I needed to modify all image references to context path relative.
> > The Struts Portlet Bridge I've developed provides adapted versions of a few
> > Struts html tags. To use these transparently, I map a different tld in
> > web.xml for the struts-html tld.
> > I'm currently working on allowing the Bridge to be used in a web application
> > context too. When that is complete the same jpetstore.war can be deployed
> > as portlet application or as web application without any needed change!
> >
> > The changes i needed to make between iteration 4 and 5 is what I'm really after.
> > As I said, I'm still working on iteration 5 (and maybe some more on 4).
> > When I have finished that (probably somewhere next week) I will check in the
> > sources for iteration 3, 4 and 5 (the latter being used as example portlet in
> > Jetspeed-2) in the Jetspeed-2 svn repository.
> > I'll let you know when I've done so.
> >
> > >
> > > 4) I have no personal plans to make iBATIS available via ibiblio, but
> > > I am not opposed to the idea.
> > Would be nice when that happens. Will make it much easier for maven based projects
> > to use iBATIS.
> >
> > Regards,
> >
> > Ate
> >
> > >
> > > Cheers,
> > > Clinton
> >
> >
>
Re: Is JPetstore (becoming) available under ASF license too?
Posted by Clinton Begin <cl...@gmail.com>.
> Great. I wasn't sure because I used the 4.0.5 source which still
> contains a license.txt claiming only you to be the license holder...
I don't see how that matters at all. I don't hold the license, I hold
the copyright. Basically, the way the license works (whether it's my
name on the copyright, or Apache), you can use it however you like.
The only thing you cannot do is claim that it's yours or otherwise not
"mine" or eventually "Apache's".
Don't let that stop you from using it.
Cheers,
Clinton
On Fri, 24 Dec 2004 21:16:13 +0100, Ate Douma <at...@douma.nu> wrote:
>
>
> Clinton Begin wrote:
> > Hi Ate,
> >
> > Sorry for the delay. To answer your questions:
> >
> > 2) Yes, you are more than welcome to include JPetStore as a sample
> > application with Jetspeed-2. It is licensed under the Apache license
> > just like the rest of iBATIS.
> Great. I wasn't sure because I used the 4.0.5 source which still
> contains a license.txt claiming only you to be the license holder...
> Have you already moved the source to an apache repository and if so,
> is it already available as such?
>
> >
> > 3) I am interested in the modifications you've made to the JSPs.
> > However, JPetStore will eventually undergo a major rewrite to correct
> > a lot of the "historical scars" and to make it a better example
> > application. I'd prefer to wait for that before making any broad
> > changes.
> As I said, I can provide you will all the changes I've made. Just let
> me know who/where I should mail it to. I have the below list of changes
> in different sets (1-3 ready) so you could use all, none or just a few :-)
>
> You should know my intention is to use the JPetstore as an example/tutorial
> how to migrate a Struts web application to a portlet application.
> For that purpose, I changed the original sources in 5 iterations:
>
> 1) Reformat the html and jsp sources to get a readable indentation
> and nesting of tags, and furthermore clean up a few superfluous
> constructions.
> To be able to compare the changes I make in each step, having
> the source in comparable structure helps a lot!
> No functional changes so far.
> 2) Split the product.description values in an imageName and description.
> The product.description contained both the html markup as well as
> the description of a pet image.
> I've changed the Item.jsp to render the image now using these
> two distinct properties.
> The reason for this action is that for a JSR-168 Portlet Application
> the rendering of an image url should be handled differently.
> This is only a technical change.
> 3) Put a ASF license header in all source files.
> As I need to check the sources into the Jetspeed-2 cvs/svn repository
> this one is required. I guess the same applies for iBATIS when you
> check in the sources in the apache svn repository.
> No technical or functional changes.
> 4) Further "strutified" the application.
> This concerns using more struts tags where appropriate, like replacing
> <form with <html:form, <a with <html:link, <input type="image with
> <html:image and <img with <html:img tags.
> This also required me to change the index.html and help.html into jsp
> files.
> No functional changes.
> 5) The final step in migrating to a Portlet Application. This involves
> a few changes to struts-config.xml like forwarding to actions instead of
> jsp files directly and plugging in my own StrutsPortletRequestProcessor.
> Furthermore, using relative url paths isn't always working in a portal
> environment because the portlet specification doesn't say how portals
> should provide a portlet with a proper context path during rendering.
> For that, I needed to modify all image references to context path relative.
> The Struts Portlet Bridge I've developed provides adapted versions of a few
> Struts html tags. To use these transparently, I map a different tld in
> web.xml for the struts-html tld.
> I'm currently working on allowing the Bridge to be used in a web application
> context too. When that is complete the same jpetstore.war can be deployed
> as portlet application or as web application without any needed change!
>
> The changes i needed to make between iteration 4 and 5 is what I'm really after.
> As I said, I'm still working on iteration 5 (and maybe some more on 4).
> When I have finished that (probably somewhere next week) I will check in the
> sources for iteration 3, 4 and 5 (the latter being used as example portlet in
> Jetspeed-2) in the Jetspeed-2 svn repository.
> I'll let you know when I've done so.
>
> >
> > 4) I have no personal plans to make iBATIS available via ibiblio, but
> > I am not opposed to the idea.
> Would be nice when that happens. Will make it much easier for maven based projects
> to use iBATIS.
>
> Regards,
>
> Ate
>
> >
> > Cheers,
> > Clinton
>
>
Re: Is JPetstore (becoming) available under ASF license too?
Posted by Ate Douma <at...@douma.nu>.
Clinton Begin wrote:
> Hi Ate,
>
> Sorry for the delay. To answer your questions:
>
> 2) Yes, you are more than welcome to include JPetStore as a sample
> application with Jetspeed-2. It is licensed under the Apache license
> just like the rest of iBATIS.
Great. I wasn't sure because I used the 4.0.5 source which still
contains a license.txt claiming only you to be the license holder...
Have you already moved the source to an apache repository and if so,
is it already available as such?
>
> 3) I am interested in the modifications you've made to the JSPs.
> However, JPetStore will eventually undergo a major rewrite to correct
> a lot of the "historical scars" and to make it a better example
> application. I'd prefer to wait for that before making any broad
> changes.
As I said, I can provide you will all the changes I've made. Just let
me know who/where I should mail it to. I have the below list of changes
in different sets (1-3 ready) so you could use all, none or just a few :-)
You should know my intention is to use the JPetstore as an example/tutorial
how to migrate a Struts web application to a portlet application.
For that purpose, I changed the original sources in 5 iterations:
1) Reformat the html and jsp sources to get a readable indentation
and nesting of tags, and furthermore clean up a few superfluous
constructions.
To be able to compare the changes I make in each step, having
the source in comparable structure helps a lot!
No functional changes so far.
2) Split the product.description values in an imageName and description.
The product.description contained both the html markup as well as
the description of a pet image.
I've changed the Item.jsp to render the image now using these
two distinct properties.
The reason for this action is that for a JSR-168 Portlet Application
the rendering of an image url should be handled differently.
This is only a technical change.
3) Put a ASF license header in all source files.
As I need to check the sources into the Jetspeed-2 cvs/svn repository
this one is required. I guess the same applies for iBATIS when you
check in the sources in the apache svn repository.
No technical or functional changes.
4) Further "strutified" the application.
This concerns using more struts tags where appropriate, like replacing
<form with <html:form, <a with <html:link, <input type="image with
<html:image and <img with <html:img tags.
This also required me to change the index.html and help.html into jsp
files.
No functional changes.
5) The final step in migrating to a Portlet Application. This involves
a few changes to struts-config.xml like forwarding to actions instead of
jsp files directly and plugging in my own StrutsPortletRequestProcessor.
Furthermore, using relative url paths isn't always working in a portal
environment because the portlet specification doesn't say how portals
should provide a portlet with a proper context path during rendering.
For that, I needed to modify all image references to context path relative.
The Struts Portlet Bridge I've developed provides adapted versions of a few
Struts html tags. To use these transparently, I map a different tld in
web.xml for the struts-html tld.
I'm currently working on allowing the Bridge to be used in a web application
context too. When that is complete the same jpetstore.war can be deployed
as portlet application or as web application without any needed change!
The changes i needed to make between iteration 4 and 5 is what I'm really after.
As I said, I'm still working on iteration 5 (and maybe some more on 4).
When I have finished that (probably somewhere next week) I will check in the
sources for iteration 3, 4 and 5 (the latter being used as example portlet in
Jetspeed-2) in the Jetspeed-2 svn repository.
I'll let you know when I've done so.
>
> 4) I have no personal plans to make iBATIS available via ibiblio, but
> I am not opposed to the idea.
Would be nice when that happens. Will make it much easier for maven based projects
to use iBATIS.
Regards,
Ate
>
> Cheers,
> Clinton
Re: Is JPetstore (becoming) available under ASF license too?
Posted by Clinton Begin <cl...@gmail.com>.
Hi Ate,
Sorry for the delay. To answer your questions:
1) Yes, you should send all inquiries for iBATIS SQL Maps, DAO and
JPetStore to the mailing lists or JIRA found on the support page
below. This will ensure the most prompt response.
http://www.ibatis.com/support.html
2) Yes, you are more than welcome to include JPetStore as a sample
application with Jetspeed-2. It is licensed under the Apache license
just like the rest of iBATIS.
3) I am interested in the modifications you've made to the JSPs.
However, JPetStore will eventually undergo a major rewrite to correct
a lot of the "historical scars" and to make it a better example
application. I'd prefer to wait for that before making any broad
changes.
4) I have no personal plans to make iBATIS available via ibiblio, but
I am not opposed to the idea.
Cheers,
Clinton
On Thu, 23 Dec 2004 11:33:01 +0100, Ate Douma <at...@douma.nu> wrote:
> I send a message to Clinton Begin 10 days ago if it would be allowed
> to use JPetstore as an example Portlet Application for Jetspeed-2.
> Because I didn't receive any response yet, and I thereafter got the
> impression you might also be moving the JPetstore sources into the
> incubator, I present my request again through this channel.
>
> I'll repeat much of my previous message below, although a bit
> rephrased in the expectancy of an ASF for JPetstore.
>
> Here it goes:
>
> I'm one of the developers of the Apache Jetspeed-2 portal.
> For the portal, we already have created a few small demo portlet applications,
> but it would be nice to also supply a more "showcase" kind of application.
> I think your JPetstore would be a fine example.
>
> I don't know how much you about Jetspeed-2 (http://portals.apache.org/jetspeed-2)
> but one type of components we deliver with it are bridges for web-framework like
> Struts, MyFaces, PHP, Perl, Velocity etc.
>
> I'm the developer of the Struts Bridge which allows Struts web applications to be
> run as JSR-168 compliant portlets. If a Struts application is properly setup
> (using true MVC model, correct use of the struts taglibs etc.) this is quite easy
> to do.
>
> So, I started out to make the JPetstore Portlet compliant. For this, I needed to
> correct several aspects in the jsp files (like not directly submitting <img...>
> tags but using <html:img... tags instead) and a few small changes to the struts-config
> file. Also, I had to modify the Product table and mapping to separate the image name
> from the description (and remove the markup) because the stored markup doesn't
> work from within a Portlet.
>
> After a few hours, I now have the JPetstore 100% working as a portlet (note: there were
> a few quicks related to the usage of com.ibatis.struts.ActionContext.setSimpleMessage
> and .addSimpleError methods, but I've transparently covered that now too).
>
> Now that I have proven this was easy to do and is working, I would like to ask you
> if you would allow my version of the JPetstore to be included as sample portlet
> in Jetspeed-2? Not only is it a nice example, it also is a perfect showcase how a
> good setup Struts application can be transformed into a portlet application without
> too many changes.
>
> Note: I kept the cleaned up version of JPetstore *before* I transformed it into a portlet
> separate. That is still a "native" web application, just more "strutsified". If you
> are interested, I can supply that version. If you agree to this request, it might be
> even nicer if you would accept those changes to JPetstore too, so that anyone interested
> can clearly compare the changes I made to transform it into a Portlet Application (almost
> none in that case).
>
> Back to embedding the portlet version into Jetspeed-2. If you agree, I would like to
> check my version in in the cvs repository of Jetspeed-2. But, because that is an Apache
> repository, it will require a Apache license for it, and hence this request.
> If you agree, will it be allowed for me to do so right away, or need I wait until you have
> checked in the JPetstore under incubator (if you are going to do so) and base my version on that?
>
> One last question about iBATIS itself. Jetspeed-2 is completely build using maven.
> Dependencies are retrieved through public remote maven repositories.
> Because I couldn't find iBATIS libraries anywhere (e.g. www.ibiblio.org/maven) I put them
> myself in my local repository.
> Do you have plans to make the iBATIS libraries available through ibiblio?
>
> Regards,
>
> Ate Douma
>
>