You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "andytaylor (via GitHub)" <gi...@apache.org> on 2024/06/03 10:31:33 UTC
[PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
andytaylor opened a new pull request, #18:
URL: https://github.com/apache/activemq-artemis-console/pull/18
This is because users can change this, the code now searched for *:broker=*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
Posted by "andytaylor (via GitHub)" <gi...@apache.org>.
andytaylor commented on PR #18:
URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2149772044
For some reason I thought the domain was configurable so I think I agree. I will close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
Posted by "andytaylor (via GitHub)" <gi...@apache.org>.
andytaylor commented on PR #18:
URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2158283290
I have made it configurable and this time actually use it, I can reopen this or raise a new PR, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
Posted by "andytaylor (via GitHub)" <gi...@apache.org>.
andytaylor closed pull request #18: ARTEMIS-4780 - Allow JMX Domain to be discoverable
URL: https://github.com/apache/activemq-artemis-console/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
Posted by "joshb1050 (via GitHub)" <gi...@apache.org>.
joshb1050 commented on PR #18:
URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2162027006
@andytaylor Up to you—whichever makes most sense. Thanks for tackling!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on PR #18:
URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2149643584
This feels off. The whole point of the domain in the object name is to avoid clashing, as some other component could easily have broker= in its mbean names.
I see from JIRA that this is coming up due to shading the broker. Presumably the console bits should be shaded too in that case? Is there a way the value could be taken from a file, such that shading it could [be made to] update that also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
Posted by "joshb1050 (via GitHub)" <gi...@apache.org>.
joshb1050 commented on PR #18:
URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2150302868
The tricky piece of this is the WAR is provided separately and so we have to run a custom shader to shade it. However it doesn't rewrite the JMX domain as part of the shading process as it's just a string in a TS file.
I think what's unexpected is the JMXDomain is configurable as one says but the console doesn't pick up on it, hence the confusion.
Custom compilation does work changing the hardcoded value and we could do that if that's the best approach forward. Thanks for looking at this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on PR #18:
URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2150011256
Well, from the JIRA I think it actually _is_ configurable on the broker (unclear why)...but seems like either noone has ever used that, or used it together with the console at the same time, or changed the console to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact