You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "hdygxsj (via GitHub)" <gi...@apache.org> on 2024/07/12 05:52:32 UTC
[PR] [Feature] Frontend supports query limit [paimon-webui]
hdygxsj opened a new pull request, #510:
URL: https://github.com/apache/paimon-webui/pull/510
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
close #503
<img width="1648" alt="image" src="https://github.com/user-attachments/assets/aec8aa39-1b62-4e40-acb5-c73e81d1210a">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Frontend supports query limit [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #510:
URL: https://github.com/apache/paimon-webui/pull/510#discussion_r1675398159
##########
paimon-web-ui/src/locales/zh/modules/playground.ts:
##########
@@ -58,4 +58,8 @@ export default {
job_stopping_successfully: '停止任务成功',
job_stopping_failed: '停止任务失败',
data_copied_successfully: '数据已复制到剪贴板',
+ execution_mode: '运行模式',
+ engine: '引擎',
+ deployment_cluster: '部署集群',
+ limit_records: '行数限制',
Review Comment:
```suggestion
limit_records: '限制行数',
```
##########
paimon-web-ui/src/views/playground/components/query/components/debugger/index.tsx:
##########
@@ -60,22 +60,26 @@ export default defineComponent({
})
const debuggerVariables = reactive<{
- operatingConditionOptions: { label: string, key: string }[]
+ operatingConditionOptions: { label: string, value: number }[]
conditionValue: string
- bigDataOptions: { label: string, value: string }[]
+ bigDataOptions: { label: string, value: string, disabled?: boolean }[]
conditionValue2: string
clusterOptions: { label: string, value: string }[]
conditionValue3: string
+ maxRows: number
executionModeOptions: { label: string, value: string }[]
}>({
operatingConditionOptions: [
- { label: 'Limit 100 items', key: '100' },
- { label: 'Limit 1000 items', key: '1000' },
+ { label: '500', value: 500 },
+ { label: '1000', value: 1000 },
+ { label: '2000', value: 2000 },
+ { label: '5000', value: 5000 },
+ { label: 'ALL', value: 2147483647 },
],
conditionValue: 'Flink',
bigDataOptions: [
{ label: 'Flink', value: 'Flink' },
- { label: 'Spark', value: 'Spark' },
+ { label: 'Spark', value: 'Spark', disabled: true },
Review Comment:
Remove spark.
##########
paimon-web-ui/src/locales/zh/modules/playground.ts:
##########
@@ -58,4 +58,8 @@ export default {
job_stopping_successfully: '停止任务成功',
job_stopping_failed: '停止任务失败',
data_copied_successfully: '数据已复制到剪贴板',
+ execution_mode: '运行模式',
+ engine: '引擎',
Review Comment:
```suggestion
engine: '执行引擎',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Frontend supports query limit [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas merged PR #510:
URL: https://github.com/apache/paimon-webui/pull/510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Frontend supports query limit [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #510:
URL: https://github.com/apache/paimon-webui/pull/510#discussion_r1675403483
##########
paimon-web-ui/src/views/playground/components/query/components/debugger/index.tsx:
##########
@@ -281,76 +286,75 @@ export default defineComponent({
return (
<div class={styles.run}>
{this.jobStatus === 'RUNNING' ? this.t('playground.stop') : this.t('playground.run')}
- <n-divider vertical />
- <n-dropdown trigger="hover" show-arrow options={this.operatingConditionOptions} on-select={this.handleSelect}>
- <n-icon component={ChevronDown} />
- </n-dropdown>
</div>
)
},
}}
>
</n-button>
- <n-select style="width:160px;" v-model:value={this.conditionValue} options={this.bigDataOptions} />
- <n-select style="width:160px;" v-model:value={this.conditionValue2} options={this.clusterOptions} />
- <n-select style="width:160px;" v-model:value={this.conditionValue3} options={this.executionModeOptions} />
+ <span>{this.t('playground.execution_mode')}</span>
+ <n-select style="width:110px;" v-model:value={this.conditionValue3} options={this.executionModeOptions} />
+ <span>{this.t('playground. execution_engine')}</span>
Review Comment:
```suggestion
<span>{this.t('playground.execution_engine')}</span>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Frontend supports query limit [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #510:
URL: https://github.com/apache/paimon-webui/pull/510#discussion_r1675402495
##########
paimon-web-ui/src/locales/zh/modules/playground.ts:
##########
@@ -58,4 +58,8 @@ export default {
job_stopping_successfully: '停止任务成功',
job_stopping_failed: '停止任务失败',
data_copied_successfully: '数据已复制到剪贴板',
+ execution_mode: '运行模式',
+ engine: '执行引擎',
Review Comment:
```suggestion
execution_engine: '执行引擎',
```
##########
paimon-web-ui/src/views/playground/components/query/components/debugger/index.tsx:
##########
@@ -281,76 +286,75 @@ export default defineComponent({
return (
<div class={styles.run}>
{this.jobStatus === 'RUNNING' ? this.t('playground.stop') : this.t('playground.run')}
- <n-divider vertical />
- <n-dropdown trigger="hover" show-arrow options={this.operatingConditionOptions} on-select={this.handleSelect}>
- <n-icon component={ChevronDown} />
- </n-dropdown>
</div>
)
},
}}
>
</n-button>
- <n-select style="width:160px;" v-model:value={this.conditionValue} options={this.bigDataOptions} />
- <n-select style="width:160px;" v-model:value={this.conditionValue2} options={this.clusterOptions} />
- <n-select style="width:160px;" v-model:value={this.conditionValue3} options={this.executionModeOptions} />
+ <span>{this.t('playground.execution_mode')}</span>
+ <n-select style="width:110px;" v-model:value={this.conditionValue3} options={this.executionModeOptions} />
+ <span>{this.t('playground.engine')}</span>
Review Comment:
```suggestion
<span>{this.t('playground. execution_engine')}</span>
```
##########
paimon-web-ui/src/locales/en/modules/playground.ts:
##########
@@ -58,4 +58,8 @@ export default {
job_stopping_successfully: 'Job Stopped Successfully',
job_stopping_failed: 'Job Stopped Failed',
data_copied_successfully: 'Data Copied to Clipboard',
+ execution_mode: 'Execution Mode',
+ engine: 'Engine',
Review Comment:
```suggestion
execution_engine: 'Execution Engine',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org