You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/03/17 05:37:58 UTC

[GitHub] [hudi] nsivabalan commented on a change in pull request #2655: [HUDI-1615] Fixing null schema for delete operation in spark datasource

nsivabalan commented on a change in pull request #2655:
URL: https://github.com/apache/hudi/pull/2655#discussion_r595725356



##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -201,9 +200,12 @@ private[hudi] object HoodieSparkSqlWriter {
             throw new HoodieException(s"hoodie table at $basePath does not exist")
           }
 
+          val tableMetaClient = HoodieTableMetaClient.builder.setConf(sparkContext.hadoopConfiguration).setBasePath(path.get).build()

Review comment:
       TableSchemaResolver fetches schema from data file footer and not commit metadata. So its all good. I tested for both COW and MOR table locally to ensure schema is fetched by TableSchemaResolver even if last commit is delete operation. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org