You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/01/06 15:01:24 UTC

[GitHub] [logging-log4j2] carterkozak commented on pull request #454: LOG4J2-2985 Add eventTemplateRootObjectKey parameter to JsonTemplateLayout.

carterkozak commented on pull request #454:
URL: https://github.com/apache/logging-log4j2/pull/454#issuecomment-755349436


   Yep, I think the changes are good, thanks! My commit was primarily an exercise to familiarize myself with the code :-)
   
   One oddity the meta revolver surfaced was that the context contains data directly describing the root object (root attribute, additional properties) that may be better decomposed into the template model rather than the context. No changes requested, just something that might be worth considering.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org