You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/18 06:52:57 UTC

[GitHub] [calcite] vlsi commented on a change in pull request #2650: [CALCITE-4949] Evaluate if using org.codelibs is appropriate for an Elasticsearch painless dependency

vlsi commented on a change in pull request #2650:
URL: https://github.com/apache/calcite/pull/2650#discussion_r771792181



##########
File path: elasticsearch/build.gradle.kts
##########
@@ -37,6 +37,9 @@ dependencies {
 
     testImplementation("org.apache.logging.log4j:log4j-api")
     testImplementation("org.apache.logging.log4j:log4j-core")
+    // Elasticsearch doesn't export painless script artifact to maven central.
+    // Using 3rd party version (codelibs) only for test.

Review comment:
       Please use `because("...")` instead of comments




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org