You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by mkedwards <gi...@git.apache.org> on 2018/11/21 21:17:28 UTC

[GitHub] zookeeper pull request #714: Zookeeper 1818 (on top of #713 to fix ZOOKEEPER...

GitHub user mkedwards opened a pull request:

    https://github.com/apache/zookeeper/pull/714

    Zookeeper 1818 (on top of #713 to fix ZOOKEEPER-2778 and ZOOKEEPER-1636 for a green build)

    Rebasing Fangmin Lyu's patch from https://github.com/lvfangmin/zookeeper/tree/ZOOKEEPER-1818 onto the 3.5 branch (cumulative with other PRs in flight).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mkedwards/zookeeper ZOOKEEPER-1818

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/714.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #714
    
----
commit 3694a4e31eef9b85de59112c22ab163452610743
Author: Michael Edwards <me...@...>
Date:   2018-11-20T13:33:09Z

    [ZOOKEEPER-2778] QuorumPeer: encapsulate quorum/election/client addresses in an AddressTuple held through an AtomicReference

commit 4cd10c86519b75521f89e451033dca4869d8d0d1
Author: Michael Edwards <michael edwards>
Date:   2018-11-21T08:53:54Z

    [ZOOKEEPER-2778] QuorumPeer/QuorumCnxManager: address deadlock and visibility issues

commit 03d259bae3b744dc494022698fa843f6cf35e7ed
Author: Michael Edwards <michael edwards>
Date:   2018-11-21T09:01:45Z

    [ZOOKEEPER-2778] QuorumPeer: add fast path for already-non-null quorum/election address

commit 0531d9c8e6a44ec531a4d8ad667307d9859bef7e
Author: Michael Edwards <michael edwards>
Date:   2018-11-21T17:13:14Z

    [ZOOKEEPER-2778] QuorumPeer: fixes from code review

commit 9701f0576f53d1859d3584d0bb9730c89eb57ac1
Author: Michael Edwards <michael edwards>
Date:   2018-11-21T17:19:44Z

    [ZOOKEEPER-2778] QuorumPeer: fix access to newly private data members from ReconfigTest

commit bbeeebf87391ef642059c4b3b65592c361a2ab4e
Author: Michael Edwards <michael edwards>
Date:   2018-11-21T19:48:49Z

    [ZOOKEEPER-2778] LeaderBeanTest: set up mock QuorumVerifier so that addresses get set

commit 0e2b571d452306ae151b106e05d0511b09a237d3
Author: Michael Edwards <michael edwards>
Date:   2018-11-21T20:31:16Z

    ZOOKEEPER-1636: cleanup completion list of a failed multi request (from Thawan Kooburat)

commit 7f286c46d505c3300a15de9d1f4849a4da84e6d3
Author: Fangmin Lyu <fa...@...>
Date:   2018-11-15T17:46:51Z

    ZOOKEEPER-1818: Correctly handle potential inconsitent zxid/electionEpoch and peerEpoch during leader election

----


---

[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

Posted by anmolnar <gi...@git.apache.org>.

Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/714
  
    @mkedwards @lvfangmin Apologies for being pushy, but this is a critical patch for the 3.5 release. Can we move on?


---

[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

Posted by anmolnar <gi...@git.apache.org>.

Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/714
  
    retest this please


---

[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

Posted by lvfangmin <gi...@git.apache.org>.

Github user lvfangmin commented on the issue:

    https://github.com/apache/zookeeper/pull/714
  
    @mkedwards I just made a 3.5 patch as well and saw this when I tried to send out, thanks for porting this over, thee change seems identical with my 3.5 one except two comments change to follow {@see}, maybe we should update that here as well.


---

[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

Posted by anmolnar <gi...@git.apache.org>.

Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/714
  
    @lvfangmin Thanks for recycling this PR. However I believe it's more convenient for the original author to port patches, but I'm happy to commit this anyway. Please let me know once who think it's ready to be committed. (...or commit it yourself)


---

[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

Posted by anmolnar <gi...@git.apache.org>.

Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/714
  
    @lvfangmin Please approve.


---

[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

Posted by mkedwards <gi...@git.apache.org>.

Github user mkedwards commented on the issue:

    https://github.com/apache/zookeeper/pull/714
  
    I updated this PR to match the changes made to #703 during review.  Anything else I can do to help?


---