You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by he...@apache.org on 2021/03/29 20:53:52 UTC
[beam] branch master updated: [BEAM-12052] Pick the correct Java
container for the executed JDK version in cross-language validate runner
tests
This is an automated email from the ASF dual-hosted git repository.
heejong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 1b1d8ad [BEAM-12052] Pick the correct Java container for the executed JDK version in cross-language validate runner tests
new 858f7ea Merge pull request #14337 from ihji/BEAM-12052
1b1d8ad is described below
commit 1b1d8ad3bb3dd5292cbacda035bcbdcc51055811
Author: Heejong Lee <he...@gmail.com>
AuthorDate: Thu Mar 25 01:24:44 2021 -0700
[BEAM-12052] Pick the correct Java container for the executed JDK version in cross-language validate runner tests
---
.../groovy/org/apache/beam/gradle/BeamModulePlugin.groovy | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index 5acc301..475a054 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -23,6 +23,7 @@ import groovy.json.JsonOutput
import groovy.json.JsonSlurper
import org.gradle.api.attributes.Category
import org.gradle.api.GradleException
+import org.gradle.api.JavaVersion
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.Task
@@ -2032,8 +2033,16 @@ class BeamModulePlugin implements Plugin<Project> {
]
def serviceArgs = project.project(':sdks:python').mapToArgString(expansionServiceOpts)
def pythonContainerSuffix = project.project(':sdks:python').pythonVersion == '2.7' ? '2' : project.project(':sdks:python').pythonVersion.replace('.', '')
+ def javaContainerSuffix
+ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
+ javaContainerSuffix = 'java8'
+ } else if (JavaVersion.current() == JavaVersion.VERSION_11) {
+ javaContainerSuffix = 'java11'
+ } else {
+ throw new GradleException("unsupported java version.")
+ }
def setupTask = project.tasks.create(name: config.name+"Setup", type: Exec) {
- dependsOn ':sdks:java:container:java8:docker'
+ dependsOn ':sdks:java:container:'+javaContainerSuffix+':docker'
dependsOn ':sdks:python:container:py'+pythonContainerSuffix+':docker'
dependsOn ':sdks:java:testing:expansion-service:buildTestExpansionServiceJar'
dependsOn ":sdks:python:installGcpTest"