You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org> on 2011/11/03 17:37:32 UTC
[jira] [Commented] (CASSANDRA-3449) Missing null check in digest
retry part of read path
[ https://issues.apache.org/jira/browse/CASSANDRA-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143293#comment-13143293 ]
Sylvain Lebresne commented on CASSANDRA-3449:
---------------------------------------------
I think it is possible for the row to be null but still being in a short read situation. Like if you resolve 2 nodes whose responses look like:
{noformat}
node1: 1 del 3
node2: del 2 del
{noformat}
and you've asked for two columns. The merging results in a null row (assuming all del have priority), but it's possible that node1 had a lot of perfectly good value after that 3, so we should retry.
I believe the right fix could be to just have a {{if (row != null)}} before the rows.add(row) ?
> Missing null check in digest retry part of read path
> ----------------------------------------------------
>
> Key: CASSANDRA-3449
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3449
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 1.0.2
>
> Attachments: 3449.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira