You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2000/10/18 02:43:31 UTC

Re: CVS update: subversion/subversion/libsvn_subr io.c

On Wed, Oct 18, 2000 at 01:13:07AM -0000, kfogel@tigris.org wrote:
>...
>   +  else if (apr_err == APR_ENOENT)         /* which is better, this test... */
>   +    *kind = svn_invalid_kind;
>   +  else if (finfo.filetype == APR_NOFILE)  /* ... or this one? */
>   +    *kind = svn_invalid_kind;

Not obvious from apr_file_io.h, but APR_NOFILE is APR's way of saying
"something is there, but I have no idea what it is."

APR_ENOENT means that nothing was there.

I'll update the APR header with this info.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: CVS update: subversion/subversion/libsvn_subr io.c

Posted by Karl Fogel <kf...@galois.collab.net>.

Greg Stein <gs...@lyra.org> writes:
> >   +  else if (apr_err == APR_ENOENT)         /* which is better, this test... */
> >   +    *kind = svn_invalid_kind;
> >   +  else if (finfo.filetype == APR_NOFILE)  /* ... or this one? */
> >   +    *kind = svn_invalid_kind;
> 
> Not obvious from apr_file_io.h, but APR_NOFILE is APR's way of saying
> "something is there, but I have no idea what it is."
> 
> APR_ENOENT means that nothing was there.

Interesting.

I'll leave both tests, then; that gets the most useful result for
Subversion.