Re: [PR] HBASE-29693: Implement the missing observer functions in the read-only controller [hbase]

["wchevreuil (via GitHub)" <gi...@apache.org>]

wchevreuil commented on code in PR #7464:
URL: https://github.com/apache/hbase/pull/7464#discussion_r2581817886


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ReadOnlyController.java:
##########
@@ -107,52 +123,136 @@ public void start(CoprocessorEnvironment env) throws IOException {
   public void stop(CoprocessorEnvironment env) {
   }
 
+  @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.UNITTEST)
+  public void setGlobalReadOnlyEnabled(boolean enabled) {
+    this.globalReadOnlyEnabled = enabled;
+  }
+

Review Comment:
   Can the tests simply set the flag in the configuration, rather than requiring this setter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org