[GitHub] [incubator-seatunnel] legendtkl commented on a diff in pull request #1742: [Feature] [seatunnel-core-flink] flink job support application mode

[GitBox <gi...@apache.org>]

legendtkl commented on code in PR #1742:
URL: https://github.com/apache/incubator-seatunnel/pull/1742#discussion_r857536465


##########
seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/command/FlinkCommandArgs.java:
##########
@@ -20,8 +20,14 @@
 import org.apache.seatunnel.common.config.DeployMode;
 import org.apache.seatunnel.config.EngineType;
 
+import com.beust.jcommander.Parameter;
+
 public class FlinkCommandArgs extends AbstractCommandArgs {
 
+    @Parameter(names = {"--application-mode"},
+        description = "run job in application mode")
+    private boolean isApplicationMode = false;

Review Comment:
   Hi, @ruanwenjun , thanks for you review. Let's have a more detail discuss.
   
   Flink use `run` and `run-application` to do different action.
   * run
     * yarn-session, kubernetes-session for `session` mode
     * yarn-per-job for `per-job` mode
   * run-application: for application mode
     * kubernetes-application, yarn-application
   
   The sub commands `yarn-session`, `kubernetes-session`, `yarn-per-job`, `kubernetes-application`, `yarn-application` could be config with `execution.target`.
   
   Now I want to distinguish the action 'run' and 'run-application', so I add `--application-mode`. 
   
   In your point, should we use executeMode (value could be 'session', 'per-job', 'application') to do more commands generate with `run`/`run-application` and `execution.target` check? or just `run` and `run-application` judgement?
   
   Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org