[GitHub] [superset] john-bodley commented on pull request #16077: fix: ensure that users viewing chart does not automatically save edit data

[GitBox <gi...@apache.org>]

john-bodley commented on pull request #16077:
URL: https://github.com/apache/superset/pull/16077#issuecomment-897091184


   I'm a little perplexed by this PR,
   
   > This pr fixes an issue where user would view charts and run queries without saving but the api would return that user had modified the chart.
   
   Shouldn't we remedy the root cause, i.e., prevent viewing of a slice from augmenting the database record, rather than adding additional columns to the table schema? This feels somewhat akin to the [There Was an Old Lady Who Swallowed a Fly
   ](https://en.wikipedia.org/wiki/There_Was_an_Old_Lady_Who_Swallowed_a_Fly) rhyme.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org