You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/09/22 10:31:32 UTC

[PR] fix(ui): drop the model picker option subtitle [maka]

Astro-Han opened a new pull request, #5585:
URL: https://github.com/apache/maka/pull/5585

   ## Summary
   
   Every model choice in the model pickers rendered a second line under its label — the catalog
   description plus a "Knowledge cutoff: …" date, joined by "·". In practice the line repeated
   what the label already says, truncated mid-sentence at the popup width
   ("DeepSeek V4.1 Flash model for reasoning an…"), and gave the reader nothing they could act
   on while doubling the height of every option row. This drops the subtitle row: model pickers
   now render icon + label only.
   
   The authoritative fix is at the option-builder seam, so every consumer loses the subtitle at
   once: `buildModelPickerOptions` and `wheelOptions` stop passing `description`, and the
   now-unused `modelChoiceDescription` helper and its `knowledgeCutoff` copy keys are deleted.
   The `locale` extra of `buildModelPickerOptions` existed only to feed that helper, so the
   parameter collapses to the optional `renderProviderMark`.
   
   Not changed: `ChatModelChoice.description` / `knowledgeCutoff` stay on the type and the wire —
   the codex app-server executor plugin has its own picker that still consumes them, and the
   switch-warning notice keeps its dismiss hint. The wheel picker keeps its `description`
   tooltip field for the plugin.
   
   ## Verification
   
   - `npm --workspace @maka/ui run build` (tsc) — clean
   - Affected suites in `packages/ui`: `chat-model-switcher-notice`, `composer-model-picker-recovery`,
     `model-wheel-picker` — 7 passed. No existing test asserted the subtitle, so nothing failed
     before the change; coverage of the option shape itself is unchanged
   - Root `npm run typecheck`, `npm run format`, `npm run lint` — clean
   - Storybook comparison, same story (`Product/Model Picker › SettingsCatalog`, real catalog
     metadata via `buildChatModelChoices`), same viewport, menu opened on the 默认模型 trigger:
   
   ![Model picker options before and after, light theme](https://github.com/user-attachments/assets/f21b9e07-bc09-42f6-b4b1-a3c46566bb5e)
   
   ![Model picker options before and after, dark theme](https://github.com/user-attachments/assets/964ab3e1-2c35-48a9-ac4e-36785dc20213)
   
   Before: every option carries a description + knowledge-cutoff line. After: icon + label only.
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Maka agent — authored the code change, verification runs, and screenshots.
   
   ## Checklist
   
   - [ ] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(ui): drop the model picker option subtitle [maka]

Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #5585:
URL: https://github.com/apache/maka/pull/5585


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org