[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration

[GitBox <gi...@apache.org>]

autumnust commented on a change in pull request #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
URL: https://github.com/apache/incubator-gobblin/pull/2780#discussion_r338715064
 
 

 ##########
 File path: gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/orc/HiveOrcSerDeManager.java
 ##########
 @@ -152,18 +147,12 @@ public void addSerDeProperties(HiveRegistrationUnit source, HiveRegistrationUnit
     if (source.getOutputFormat().isPresent()) {
       target.setOutputFormat(source.getOutputFormat().get());
     }
-    if (source.getSerDeProps().contains(SCHEMA_LITERAL)) {
-      target.setSerDeProp(SCHEMA_LITERAL, source.getSerDeProps().getProp(SCHEMA_LITERAL));
-    }
   }
 
   @Override
   public void updateSchema(HiveRegistrationUnit existingUnit, HiveRegistrationUnit newUnit)
       throws IOException {
-    Preconditions.checkArgument(
-        newUnit.getSerDeProps().contains(SCHEMA_LITERAL));
-
-    existingUnit.setSerDeProp(SCHEMA_LITERAL, newUnit.getSerDeProps().getProp(SCHEMA_LITERAL));
+    log.debug("Do nothing to update schema since orc.schema.literal is removed");
 
 Review comment:
   Getting rid of this method override 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services