[GitHub] [incubator-druid] clintropolis opened a new pull request #7655: allow sql lookup function to take advantage of injective lookups

[GitBox <gi...@apache.org>]

clintropolis opened a new pull request #7655: allow sql lookup function to take advantage of injective lookups
URL: https://github.com/apache/incubator-druid/pull/7655
 
 
   Currently the `LOOKUP` function is hard coded to set `injective` to false, which does not allow it to take advantage of lookups which were defined as `injective` which are detected from the lookup factories if the `injective` parameter is `null`.
   
   This PR changes it to use `null` instead of `false`. This does mean that any lookup factory that produces an extractor that identifies as `ONE_TO_ONE` but has missing values will produce incorrect aggregation results for the 'unknown' values.
   
   I haven't determined a good way to write a test for this, as there are a few layers of indirection between here and where the one to one optimization happens.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org