You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Paul Rogers (Code Review)" <ge...@cloudera.org> on 2018/10/26 22:32:20 UTC
[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog
Hello Bharath Vissapragada, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11688
to look at the new patch set (#2).
Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog
......................................................................
IMPALA-7501: Slim down metastore Partition objects in LocalCatalog
Used existing method to remove cached per-partition column information
as requested in the JIRA ticket. See IMPALA-7501 for details.
Then, revised catalogd to not include the unwanted partition schema
info when re-creating an HMS parition object.
Cleaned up a few unused imports in test files used during this effort.
Tested by inspecting a heap dump before and after the change to ensure
that the column schema is no longer referenced from the Hive Partition
objects. (At present, we have no automated way to inspect a heap dump.)
Change-Id: I4c861452cf974970ab511406fe2e175ea3dc668d
---
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoTest.java
5 files changed, 5 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/11688/2
--
To view, visit http://gerrit.cloudera.org:8080/11688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4c861452cf974970ab511406fe2e175ea3dc668d
Gerrit-Change-Number: 11688
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>