Re: [PR] [QDP] feat: add credit card fraud benchmark + amplitude encoding optimizations [mahout]

["guan404ming (via GitHub)" <gi...@apache.org>]

guan404ming commented on PR #1106:
URL: https://github.com/apache/mahout/pull/1106#issuecomment-4191008578

   > Great catch! You are right that the code in take_batch_from_source() was misleading.
   Actually, next_batch() already handles the InMemory variant directly using the zero-copy data[start..end] slice logic and never calls take_batch_from_source() for it. To avoid confusion and make the implementation match the documentation claims, I've replaced the dead-code InMemory arm in take_batch_from_source() with unreachable!().
   I've also rebased the branch onto main and resolved all the merge conflicts. Thanks for the review!
   
   Make sense to me, thanks for the update. I could code change wise looks nie, plz help resolve the conflict, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org