[jira] [Commented] (BEAM-3636) DirectRunner proto roundtrip masks stable name errors

["Kenneth Knowles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387295#comment-16387295 ] 

Kenneth Knowles commented on BEAM-3636:
---------------------------------------

I expect that this will mean that the ReferenceRunner also has to address this.

> DirectRunner proto roundtrip masks stable name errors
> -----------------------------------------------------
>
>                 Key: BEAM-3636
>                 URL: https://issues.apache.org/jira/browse/BEAM-3636
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>            Priority: Critical
>
> Example failure: https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/org.apache.beam$beam-sdks-java-io-hbase/17584/testReport/junit/org.apache.beam.sdk.io.hbase/HBaseIOTest/testReadingWithKeyRange/
> {code}
> Pipeline update will not be possible because the following transforms do not have stable unique names: PAssert$2/CreateActual/View.AsSingleton/Combine.GloballyAsSingletonView/Combine.globally(Singleton)/Combine.perKey(Singleton)/GroupByKey, CountTEST-KEY-RANGE-TABLE_ByteKeyRange{startKey=[], endKey=[32]}/Combine.perKey(Count)/GroupByKey.
> Conflicting instances:
> - name=PAssert$2/CreateActual/View.AsSingleton/Combine.GloballyAsSingletonView/Combine.globally(Singleton)/Combine.perKey(Singleton)/GroupByKey:
>     - GroupByKey
>     - GroupByKey
> - name=CountTEST-KEY-RANGE-TABLE_ByteKeyRange{startKey=[], endKey=[32]}/Combine.perKey(Count)/GroupByKey:
>     - GroupByKey
>     - GroupByKey
> You can fix it adding a name when you call apply(): pipeline.apply(<name>, <transform>).
> {code}
> The test clearly does have stable name errors. This was exposed by reverting the proto roundtrip in the DirectRunner. Precommit and postcommit are otherwise green, so this is being masked.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)