You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/09/15 06:26:46 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #42942: [SPARK-45168][PYTHON][FOLLOWUP] Code Cleanup
zhengruifeng opened a new pull request, #42942:
URL: https://github.com/apache/spark/pull/42942
### What changes were proposed in this pull request?
remove unreachable code path
### Why are the changes needed?
code cleanup
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
CI
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42942: [SPARK-45168][PYTHON][FOLLOWUP] `test_missing_data.py` Code Cleanup
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42942:
URL: https://github.com/apache/spark/pull/42942#issuecomment-1720943164
thanks @dongjoon-hyun , merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42942: [SPARK-45168][PYTHON][FOLLOWUP] `test_missing_data.py` Code Cleanup
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42942: [SPARK-45168][PYTHON][FOLLOWUP] `test_missing_data.py` Code Cleanup
URL: https://github.com/apache/spark/pull/42942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42942: [SPARK-45168][PYTHON][FOLLOWUP] `test_missing_data.py` Code Cleanup
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42942:
URL: https://github.com/apache/spark/pull/42942#issuecomment-1720745593
after this PR,
```
(spark_dev_310) ➜ spark git:(inc_pd_clean_up) ag --py 'pandas\.__version' python
python/pyspark/sql/pandas/utils.py
37: if LooseVersion(pandas.__version__) < LooseVersion(minimum_pandas_version):
40: "your version was %s." % (minimum_pandas_version, pandas.__version__)
(spark_dev_310) ➜ spark git:(inc_pd_clean_up) ag --py 'pd\.__version' python
python/pyspark/pandas/supported_api_gen.py
102: if LooseVersion(pd.__version__) != LooseVersion(pandas_latest_version):
105: "however, your version was %s" % (pandas_latest_version, pd.__version__)
python/pyspark/pandas/tests/series/test_compute.py
490: LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
python/pyspark/pandas/tests/test_stats.py
169: LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
python/pyspark/pandas/tests/test_dataframe_spark_io.py
102: if LooseVersion(pd.__version__) > LooseVersion("1.5.0"):
python/pyspark/pandas/tests/test_series_conversion.py
53: LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
python/pyspark/pandas/tests/test_ops_on_diff_frames.py
497: LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
python/pyspark/pandas/tests/test_series_datetime.py
201: LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
208: LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
python/pyspark/pandas/tests/groupby/test_split_apply.py
44: LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
python/pyspark/pandas/tests/groupby/test_index.py
44: LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
python/pyspark/pandas/tests/groupby/test_stat.py
248: LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
python/pyspark/pandas/tests/computation/test_corrwith.py
62: if LooseVersion(pd.__version__) == LooseVersion("1.5.0") and isinstance(pobj, pd.Series):
python/pyspark/pandas/tests/test_dataframe_conversion.py
206: LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
python/pyspark/pandas/tests/diff_frames_ops/test_cov_corrwith.py
133: if LooseVersion(pd.__version__) == LooseVersion("1.5.0"):
149: if LooseVersion(pd.__version__) == LooseVersion("1.5.0"):
python/pyspark/pandas/tests/indexes/test_datetime.py
101: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
python/pyspark/pandas/tests/indexes/test_category.py
205: if LooseVersion(pd.__version__) >= LooseVersion("1.5.0"):
python/pyspark/pandas/tests/indexes/test_base.py
202: if LooseVersion(pd.__version__) < LooseVersion("1.5.0"):
284: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
459: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1517: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1590: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1604: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1618: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1632: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1646: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1661: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1675: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1683: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1694: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1702: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1710: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
1718: if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
python/pyspark/pandas/utils.py
580: % (pd.__version__, param.name, pandas_func.__name__)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42942: [SPARK-45168][PYTHON][FOLLOWUP] `test_missing_data.py` Code Cleanup
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42942:
URL: https://github.com/apache/spark/pull/42942#issuecomment-1720747786
thanks @dongjoon-hyun
the CI link is https://github.com/zhengruifeng/spark/actions/runs/6194672684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org