You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/09 10:01:57 UTC
[GitHub] [doris] caiconghui opened a new pull request, #10719: [enhancement](alter) Make alter job more robust by ignoring some task failure
caiconghui opened a new pull request, #10719:
URL: https://github.com/apache/doris/pull/10719
# Proposed changes
Issue Number: close #10718
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10719: [enhancement](alter) Make alter job more robust by ignoring some task failure
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10719:
URL: https://github.com/apache/doris/pull/10719#issuecomment-1179648559
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10719: [enhancement](alter) Make alter job more robust by ignoring some task failure
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10719:
URL: https://github.com/apache/doris/pull/10719#discussion_r917328443
##########
fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java:
##########
@@ -444,6 +456,12 @@ protected void runRunningJob() throws AlterCancelException {
tbl.writeLockOrAlterCancelException();
try {
Preconditions.checkState(tbl.getState() == OlapTableState.ROLLUP);
+ TabletInvertedIndex invertedIndex = Catalog.getCurrentInvertedIndex();
+ for (List<AgentTask> tasks : failedAgentTasks.values()) {
+ for (AgentTask task : tasks) {
+ invertedIndex.getReplica(task.getTabletId(), task.getBackendId()).setBad(true);
Review Comment:
This tablet id is new rollup tabeltid or base tablet id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #10719: [enhancement](alter) Make alter job more robust by ignoring some task failure
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10719:
URL: https://github.com/apache/doris/pull/10719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10719: [enhancement](alter) Make alter job more robust by ignoring some task failure
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10719:
URL: https://github.com/apache/doris/pull/10719#issuecomment-1179648563
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] caiconghui commented on pull request #10719: [enhancement](alter) Make alter job more robust by ignoring some task failure
Posted by GitBox <gi...@apache.org>.
caiconghui commented on PR #10719:
URL: https://github.com/apache/doris/pull/10719#issuecomment-1179878159
> LGTM But did you test it in real env? How to test it?
> LGTM But did you test it in real env? How to test it?
not yet, but it can simply stop one be after doing some alter operation, then what we expected is final successful alter job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10719: [enhancement](alter) Make alter job more robust by ignoring some task failure
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10719:
URL: https://github.com/apache/doris/pull/10719#discussion_r917330602
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java:
##########
@@ -494,22 +492,38 @@ protected void runRunningJob() throws AlterCancelException {
List<AgentTask> tasks = schemaChangeBatchTask.getUnfinishedTasks(2000);
for (AgentTask task : tasks) {
if (task.getFailedTimes() >= 3) {
- throw new AlterCancelException("schema change task failed after try three times: "
- + task.getErrorMsg());
+ task.setFinished(true);
+ AgentTaskQueue.removeTask(task.getBackendId(), TTaskType.ALTER, task.getSignature());
+ LOG.warn("schema change task failed after try three times: " + task.getErrorMsg());
+ if (!failedAgentTasks.containsKey(task.getTabletId())) {
+ failedAgentTasks.put(task.getTabletId(), Lists.newArrayList(task));
+ } else {
+ failedAgentTasks.get(task.getTabletId()).add(task);
+ }
+ int expectSucceedTaskNum = tbl.getPartitionInfo()
+ .getReplicaAllocation(task.getPartitionId()).getTotalReplicaNum();
+ int failedTaskCount = failedAgentTasks.get(task.getTabletId()).size();
Review Comment:
why not use the replica num in config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] caiconghui commented on a diff in pull request #10719: [enhancement](alter) Make alter job more robust by ignoring some task failure
Posted by GitBox <gi...@apache.org>.
caiconghui commented on code in PR #10719:
URL: https://github.com/apache/doris/pull/10719#discussion_r917328465
##########
fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java:
##########
@@ -444,6 +456,12 @@ protected void runRunningJob() throws AlterCancelException {
tbl.writeLockOrAlterCancelException();
try {
Preconditions.checkState(tbl.getState() == OlapTableState.ROLLUP);
+ TabletInvertedIndex invertedIndex = Catalog.getCurrentInvertedIndex();
+ for (List<AgentTask> tasks : failedAgentTasks.values()) {
+ for (AgentTask task : tasks) {
+ invertedIndex.getReplica(task.getTabletId(), task.getBackendId()).setBad(true);
Review Comment:
new rollup tablet id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] caiconghui commented on a diff in pull request #10719: [enhancement](alter) Make alter job more robust by ignoring some task failure
Posted by GitBox <gi...@apache.org>.
caiconghui commented on code in PR #10719:
URL: https://github.com/apache/doris/pull/10719#discussion_r917330814
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java:
##########
@@ -494,22 +492,38 @@ protected void runRunningJob() throws AlterCancelException {
List<AgentTask> tasks = schemaChangeBatchTask.getUnfinishedTasks(2000);
for (AgentTask task : tasks) {
if (task.getFailedTimes() >= 3) {
- throw new AlterCancelException("schema change task failed after try three times: "
- + task.getErrorMsg());
+ task.setFinished(true);
+ AgentTaskQueue.removeTask(task.getBackendId(), TTaskType.ALTER, task.getSignature());
+ LOG.warn("schema change task failed after try three times: " + task.getErrorMsg());
+ if (!failedAgentTasks.containsKey(task.getTabletId())) {
+ failedAgentTasks.put(task.getTabletId(), Lists.newArrayList(task));
+ } else {
+ failedAgentTasks.get(task.getTabletId()).add(task);
+ }
+ int expectSucceedTaskNum = tbl.getPartitionInfo()
+ .getReplicaAllocation(task.getPartitionId()).getTotalReplicaNum();
+ int failedTaskCount = failedAgentTasks.get(task.getTabletId()).size();
Review Comment:
we are not sure the status of all agent tasks, but we can confirm that replica with failed task is bad, the job is still in running state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org