You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/12/31 01:33:24 UTC
[GitHub] [netbeans] rs333 opened a new pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
rs333 opened a new pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625
**Recommended Retest**
1. Start netbeans
2. Enter Options->Fonts & Colors
3. Select XML for the language
4. Select Pi Content
5. Change the Foreground color to something other than the default [0,0,124] (Which is illegible in FlatLafDark)
6. Note that the color in the preview box changes. (The text `version="1.0"`)
6. Exit netbeans
7. Repeat steps 1-3
8. Verify `version="1.0"` is the newly selected color.
Note 1: In the master branch (and many versions before that), after restarting netbeans, the color will be restored to the original [0,0,124]
Note 2: This fix also fixes the name styling for the PI Target and PI End Delimiter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-753048126
Thank you - the update of the author information looks good. For the removal of the unnessary changes, please amend that commit. Yes, in general changes should be added in new commits, but this PR is so small, that we can work on the final commit.
For the reference: Yes that is what I meant. You are seeing a pass file for an integration test - but these are disable for xml.text. Looks like someone restructured xml support and "forgot" about that. Please update that file with the new category, so that at least if someone decides to care, he will not try to change the token name back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing edited a comment on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing edited a comment on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-752951195
Thank you - I have the following comments:
- [ ] Are the changes to java files really necessary? While I see, that the change to `ide/xml.lexer/src/org/netbeans/api/xml/lexer/XMLTokenId.java` creates consistency, I wonder if the change to `ide/xml.text.obsolete90/src/org/netbeans/modules/xml/text/syntax/XMLTokenIDs.java` is needed.
- [ ] Did you check if the code base uses the changes primary-category/name?
- [ ] Your git configuration is broken, the author information is invalid. Please ensure, that you commit with your real name and a valid email address. You can check the used information with the git command line client and running `git log -n 1` from the branch you used to create this PR.
- [x] Are you aware, that you donate the change to the ASF and agree to that (see the comment at the top of the files you change)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rs333 commented on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
rs333 commented on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-753227487
> Thank you - the update of the author information looks good. For the removal of the unnessary changes, please amend that commit. Yes, in general changes should be added in new commits, but this PR is so small, that we can work on the final commit.
>
> For the reference: Yes that is what I meant. You are seeing a pass file for an integration test - but these are disable for xml.text. Looks like someone restructured xml support and "forgot" about that. Please update that file with the new category, so that at least if someone decides to care, he will not try to change the token name back.
I believe all should be in order now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rs333 edited a comment on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
rs333 edited a comment on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-752995993
> Thank you - I have the following comments:
>
> * [ ] Are the changes to java files really necessary? While I see, that the change to `ide/xml.lexer/src/org/netbeans/api/xml/lexer/XMLTokenId.java` creates consistency, I wonder if the change to `ide/xml.text.obsolete90/src/org/netbeans/modules/xml/text/syntax/XMLTokenIDs.java` is needed.
I agree the file in the xml.text.obsolete90 folder need not be changed. I can remove those changes.
> * [ ] Did you check if the code base uses the changes primary-category/name?
If I understand your question correction, yes. There is one file which does not appear to be used anymore (like the one from the first comment) which I did not change that references `pi-content`. It is
`ide/xml.text/test/qa-functional/src/org/netbeans/modules/xml/text/syntax/data/goldenfiles/ColoringTest/testXMLColoring.pass`
> * [ ] Your git configuration is broken, the author information is invalid. Please ensure, that you commit with your real name and a valid email address. You can check the used information with the git command line client and running `git log -n 1` from the branch you used to create this PR.
Will fix this.
> * [ ] Are you aware, that you donate the change to the ASF and agree to that (see the comment at the top of the files you change)?
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rs333 commented on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
rs333 commented on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-752850636
Not sure why the 2 tests that failed did so. As can be seen from here, they both pass which means all the tests pass.
https://travis-ci.org/github/rs333/netbeans/builds/752232783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-752951195
Thank you - I have the following comments:
- [ ] Are the changes to java files really necessary? While I see, that the change to `ide/xml.lexer/src/org/netbeans/api/xml/lexer/XMLTokenId.java` creates consistency, I wonder if the change to `ide/xml.text.obsolete90/src/org/netbeans/modules/xml/text/syntax/XMLTokenIDs.java` is needed.
- [ ] Did you check if the code base uses the changes primary-category/name?
- [ ] Your git configuration is broken, the author information is invalid. Please ensure, that you commit with your real name and a valid email address. You can check the used information with the git command line client and running `git log -n 1` from the branch you used to create this PR.
- [ ] Are you aware, that you donate the change to the ASF and agree to that (see the comment at the top of the files you change)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing edited a comment on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing edited a comment on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-752951195
Thank you - I have the following comments:
- [ ] Are the changes to java files really necessary? While I see, that the change to `ide/xml.lexer/src/org/netbeans/api/xml/lexer/XMLTokenId.java` creates consistency, I wonder if the change to `ide/xml.text.obsolete90/src/org/netbeans/modules/xml/text/syntax/XMLTokenIDs.java` is needed.
- [ ] Did you check if the code base uses the changes primary-category/name?
- [x] Your git configuration is broken, the author information is invalid. Please ensure, that you commit with your real name and a valid email address. You can check the used information with the git command line client and running `git log -n 1` from the branch you used to create this PR.
- [x] Are you aware, that you donate the change to the ASF and agree to that (see the comment at the top of the files you change)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-753347959
I was not able to reproduce the originally stated problem, but I had a look at other places in the codebase and they all expect the names in the new form. This should improve the situation for the existing themes, make it more consistent and if it fixes also the problem seen by others, great :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rs333 edited a comment on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
rs333 edited a comment on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-752995993
> Thank you - I have the following comments:
>
> * [ ] Are the changes to java files really necessary? While I see, that the change to `ide/xml.lexer/src/org/netbeans/api/xml/lexer/XMLTokenId.java` creates consistency, I wonder if the change to `ide/xml.text.obsolete90/src/org/netbeans/modules/xml/text/syntax/XMLTokenIDs.java` is needed.
I agree the file in the xml.text.obsolete90 folder need not be changed. I can remove those changes. Shoudl I ammend my commit or simply add another that removes the file?
> * [ ] Did you check if the code base uses the changes primary-category/name?
If I understand your question correction, yes. There is one file which does not appear to be used anymore (like the one from the first comment) which I did not change that references `pi-content`. It is
`ide/xml.text/test/qa-functional/src/org/netbeans/modules/xml/text/syntax/data/goldenfiles/ColoringTest/testXMLColoring.pass`
> * [ ] Your git configuration is broken, the author information is invalid. Please ensure, that you commit with your real name and a valid email address. You can check the used information with the git command line client and running `git log -n 1` from the branch you used to create this PR.
Will fix this.
> * [ ] Are you aware, that you donate the change to the ASF and agree to that (see the comment at the top of the files you change)?
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing edited a comment on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing edited a comment on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-752951195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rs333 commented on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
rs333 commented on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-752995993
> Thank you - I have the following comments:
>
> * [ ] Are the changes to java files really necessary? While I see, that the change to `ide/xml.lexer/src/org/netbeans/api/xml/lexer/XMLTokenId.java` creates consistency, I wonder if the change to `ide/xml.text.obsolete90/src/org/netbeans/modules/xml/text/syntax/XMLTokenIDs.java` is needed.
I agree the file in the xml.text.obsolete90 folder need not be changed. I can remove those changes.
> * [ ] Did you check if the code base uses the changes primary-category/name?
If I understand your question correction, yes. There is one file which does not appear to be used anymore (like the one from the first comment) which I did not change that references `pi-content`. It is
`ide/xml.text/test/qa-functional/src/org/netbeans/modules/xml/text/syntax/data/goldenfiles/ColoringTest/testXMLColoring.pass`
> * [ ] Your git configuration is broken, the author information is invalid. Please ensure, that you commit with your real name and a valid email address. You can check the used information with the git command line client and running `git log -n 1` from the branch you used to create this PR.
Will fix this. Should I create create a new pull request or can I update the branches history. I saw this in the submission guidelines and didn't want to cause trouble. "After submission (and certainly after someone starts reviewing the PR) you shouldn’t touch the PR’s history"
> * [ ] Are you aware, that you donate the change to the ASF and agree to that (see the comment at the top of the files you change)?
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists