You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Swapan Shridhar <ss...@hortonworks.com> on 2017/02/02 00:58:50 UTC

Review Request 56198: ADDENDUM. AMBARI-19814. Backend path for 'num_llap_nodes' should show up as non-editable property when non-ambari managed queue is selected.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56198/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Bugs: AMBARI-19814
    https://issues.apache.org/jira/browse/AMBARI-19814


Repository: ambari


Description
-------

Backend code change for using the config attribute 'read-only' instead of 'visible'.
UI changes have already been checked-in and this is an addendum backend patch.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py fe9737a 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py fe58217 

Diff: https://reviews.apache.org/r/56198/diff/


Testing
-------


Thanks,

Swapan Shridhar


Re: Review Request 56198: ADDENDUM. AMBARI-19814. Backend path for 'num_llap_nodes' should show up as non-editable property when non-ambari managed queue is selected.

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56198/#review163918
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 2, 2017, 12:58 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56198/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 12:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19814
>     https://issues.apache.org/jira/browse/AMBARI-19814
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Backend code change for using the config attribute 'read-only' instead of 'visible'.
> UI changes have already been checked-in and this is an addendum backend patch.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py fe9737a 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py fe58217 
> 
> Diff: https://reviews.apache.org/r/56198/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>


Re: Review Request 56198: ADDENDUM. AMBARI-19814. Backend path for 'num_llap_nodes' should show up as non-editable property when non-ambari managed queue is selected.

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56198/#review163919
-----------------------------------------------------------


Ship it!




Ship It!

- Jaimin Jetly


On Feb. 2, 2017, 12:58 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56198/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 12:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19814
>     https://issues.apache.org/jira/browse/AMBARI-19814
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Backend code change for using the config attribute 'read-only' instead of 'visible'.
> UI changes have already been checked-in and this is an addendum backend patch.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py fe9737a 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py fe58217 
> 
> Diff: https://reviews.apache.org/r/56198/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>