[GitHub] [trafficcontrol] jhg03a commented on a change in pull request #5072: fixes ansible-based lab deployment code to account for recent changes made to traffic_portal_properties.json

[GitBox <gi...@apache.org>]

jhg03a commented on a change in pull request #5072:
URL: https://github.com/apache/trafficcontrol/pull/5072#discussion_r495117240



##########
File path: traffic_portal/app/src/common/modules/header/HeaderController.js
##########
@@ -23,9 +23,9 @@ var HeaderController = function($rootScope, $scope, $state, $uibModal, $location
 
     $scope.userLoaded = userModel.loaded;
 
-    $scope.enviroName = propertiesModel.properties.environment.name;
+    $scope.enviroName = (propertiesModel.properties.environment) ? propertiesModel.properties.environment.name : '';
 
-    $scope.isProd = propertiesModel.properties.environment.isProd;
+    $scope.isProd = (propertiesModel.properties.environment) ? propertiesModel.properties.environment.isProd : false;

Review comment:
       Should this safety check be for `propertiesModel.properties.environment.isProd`?

##########
File path: traffic_portal/app/src/common/modules/header/HeaderController.js
##########
@@ -23,9 +23,9 @@ var HeaderController = function($rootScope, $scope, $state, $uibModal, $location
 
     $scope.userLoaded = userModel.loaded;
 
-    $scope.enviroName = propertiesModel.properties.environment.name;
+    $scope.enviroName = (propertiesModel.properties.environment) ? propertiesModel.properties.environment.name : '';

Review comment:
       Should this safety check be for `propertiesModel.properties.environment.name`?

##########
File path: infrastructure/ansible/roles/traffic_portal/defaults/main.yml
##########
@@ -42,7 +42,14 @@ tp_default_properties_template:
   _comment: These are the default properties for Traffic Portal. Customize these values
     to fit your needs.
   properties:
+    _comments:
+      name: Customize the name of Traffic Portal if desired.
+      enforceCapabilities: Not currently supported. Must be false.

Review comment:
       is `Not currently supported. Must be false.` a comment?  If so, please put it on a separate line like `# Not currently supported. Must be false.` and make the actual value `false`

##########
File path: traffic_portal/app/src/common/modules/navigation/NavigationController.js
##########
@@ -21,7 +21,7 @@ var NavigationController = function($scope, $log, $state, $location, $window, $t
 
     $scope.appName = propertiesModel.properties.name;
 
-    $scope.isProd = propertiesModel.properties.environment.isProd;
+    $scope.isProd = (propertiesModel.properties.environment) ? propertiesModel.properties.environment.isProd : false;

Review comment:
       Should this safety check be for `propertiesModel.properties.environment.isProd`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org