You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/10 05:32:19 UTC
Re: Review Request 37110: Enabled the Authorizer to handle
Reserve/Unreserve ACLs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37110/#review98339
-----------------------------------------------------------
src/tests/authorization_tests.cpp (line 397)
<https://reviews.apache.org/r/37110/#comment154752>
// "bar" principal cannot unreserve anyone's resources.
Also you may want a rebase as the main logic is now moved to src/authorizer/local/authorizer.cpp
- Guangya Liu
On 八月 5, 2015, 9:58 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37110/
> -----------------------------------------------------------
>
> (Updated 八月 5, 2015, 9:58 a.m.)
>
>
> Review request for mesos, Adam B and Jie Yu.
>
>
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f
> src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc
> src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87
> src/tests/mesos.hpp 20418d4fbd2f4ae35ee0c707472cbf37125883b0
>
> Diff: https://reviews.apache.org/r/37110/diff/
>
>
> Testing
> -------
>
> Added tests to `src/tests/authorization_tests.cpp` + `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 37110: Enabled the Authorizer to handle
Reserve/Unreserve ACLs.
Posted by Till Toenshoff <to...@me.com>.
On Sept. 10, 2015, 3:32 a.m., Michael Park wrote:
> > Also you may want a rebase as the main logic is now moved to src/authorizer/local/authorizer.cpp
Seems fixed in https://reviews.apache.org/r/39986
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37110/#review98339
-----------------------------------------------------------
On Sept. 12, 2015, 9:30 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37110/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2015, 9:30 a.m.)
>
>
> Review request for mesos, Adam B, Jie Yu, and Till Toenshoff.
>
>
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f
> src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc
> src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87
> src/tests/mesos.hpp 20418d4fbd2f4ae35ee0c707472cbf37125883b0
>
> Diff: https://reviews.apache.org/r/37110/diff/
>
>
> Testing
> -------
>
> Added tests to `src/tests/authorization_tests.cpp` + `make check`
>
>
> Thanks,
>
> Michael Park
>
>