You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2026/09/29 12:59:10 UTC
[PR] fix(mcp): skip dashboard live updates when websockets are disabled [superset]
aminghadersohi opened a new pull request, #44796:
URL: https://github.com/apache/superset/pull/44796
### SUMMARY
Require a truthy `WEBSOCKET_ENABLE` before publishing a dashboard filter notification. When websockets are disabled or unset, the MCP tool still returns the dashboard permalink but reports `live_update_pushed: false` and does not publish.
Gate location: `_publish_filters_applied`, not `publish_realtime`. A repository-wide caller search found the dashboard tool and TaskManager's wrapper (used by entity-change and task-status notifications). The task publishers have an independent coordination-backend-based contract and an initialized channel override. Keeping the gate in the dashboard tool fixes its response without changing those legacy task publishers.
Update the MCP documentation and parameterize regression coverage for enabled, disabled, and unset websocket configuration, alongside missing-backend and publish-failure cases. Existing guest routing coverage explicitly enables websockets.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; backend notification behavior only.
### TESTING INSTRUCTIONS
- `PYTHONPATH=.:superset-core/src pytest -q tests/unit_tests/mcp_service/dashboard/tool/test_apply_dashboard_filters.py tests/unit_tests/test_realtime_publish.py`
- `pre-commit run` on the three explicitly staged files, including mypy.
- `PYTHONPATH=.:superset-core/src pylint --rcfile=.pylintrc --load-plugins=superset.extensions.pylint --reports=no superset/mcp_service/dashboard/tool/apply_dashboard_filters.py`
- With a coordination backend configured, call `apply_dashboard_filters` with websockets disabled: verify that no notification is published, `live_update_pushed` is false, and the permalink is returned. Enable websockets and repeat with an authenticated principal: a successful publish reports true.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): skip dashboard live updates when websockets are disabled [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44796:
URL: https://github.com/apache/superset/pull/44796#issuecomment-5891781406
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44796?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `33.33333%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.29%. Comparing base ([`ce86ac9`](https://app.codecov.io/gh/apache/superset/commit/ce86ac9aefcbf4fa4448909f9c9fa818206bdf4a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5dcf71f`](https://app.codecov.io/gh/apache/superset/commit/5dcf71f8c4cef3c3d5aab5b57253a5100cc26f53?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/44796?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...\_service/dashboard/tool/apply\_dashboard\_filters.py](https://app.codecov.io/gh/apache/superset/pull/44796?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fdashboard%2Ftool%2Fapply_dashboard_filters.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvZGFzaGJvYXJkL3Rvb2wvYXBwbHlfZGFzaGJvYXJkX2ZpbHRlcnMucHk=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/44796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44796 +/- ##
===========================================
- Coverage 81.52% 57.29% -24.24%
===========================================
Files 2974 2974
Lines 180288 180291 +3
Branches 41741 41742 +1
===========================================
- Hits 146980 103290 -43690
- Misses 30585 75994 +45409
+ Partials 2723 1007 -1716
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44796/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage ฮ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/44796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.70% <33.33%> (-0.01%)` | :arrow_down: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/44796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/44796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/44796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.62% <33.33%> (-0.01%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/44796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.67% <33.33%> (-46.98%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/44796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/44796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44796?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): skip dashboard live updates when websockets are disabled [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44796:
URL: https://github.com/apache/superset/pull/44796#issuecomment-5890797824
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): skip dashboard live updates when websockets are disabled [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44796:
URL: https://github.com/apache/superset/pull/44796#issuecomment-5892541871
<!-- Bito Reply -->
The flagged issue is correct. The current implementation only checks if `WEBSOCKET_ENABLE` is set, but it fails to verify if the principal has the necessary `can_read` permission on the `Realtime` resource, leading to a false success report when the user lacks authorization.
To resolve this, you should update `_publish_filters_applied` in `superset/mcp_service/dashboard/tool/apply_dashboard_filters.py` to include a permission check using `security_manager.can_read_permission` or similar authorization logic before returning `True`.
Would you like me to implement this permission check and check the rest of the PR comments for you?
**superset/mcp_service/dashboard/tool/apply_dashboard_filters.py**
```
if not current_app.config.get("WEBSOCKET_ENABLE"):
return False
# Add permission check here:
# if not security_manager.can_read_permission("Realtime", ...):
# return False
if not CoordinationService.is_backend_defined():
return False
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): skip dashboard live updates when websockets are disabled or realtime access is missing [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi merged PR #44796:
URL: https://github.com/apache/superset/pull/44796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): skip dashboard live updates when websockets are disabled [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44796:
URL: https://github.com/apache/superset/pull/44796#issuecomment-5907525599
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): skip dashboard live updates when websockets are disabled [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44796:
URL: https://github.com/apache/superset/pull/44796#issuecomment-5890830291
### <span aria-hidden="true">โ
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">๐จ</span> Latest commit | 5dcf71f8c4cef3c3d5aab5b57253a5100cc26f53 |
|<span aria-hidden="true">๐</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6abbb61fb4d9590009126b04 |
|<span aria-hidden="true">๐</span> Deploy Preview | [https://deploy-preview-44796--superset-docs-preview.netlify.app](https://deploy-preview-44796--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">๐ฑ</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">๐ค</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DYtbCoAgEADvst8tqKVgN-gYrm4PeihlRUR3z78ZmHkh7XFNGVqACmh3mx8LHx6lqpU2uEwX45mCy4w30xH9zBmHoqUPnJb4dKEcxhGRkT01wWorhLBSGRINfD8) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-44796--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): skip dashboard live updates when websockets are disabled [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on code in PR #44796:
URL: https://github.com/apache/superset/pull/44796#discussion_r4141119566
##########
superset/mcp_service/dashboard/tool/apply_dashboard_filters.py:
##########
@@ -73,6 +74,8 @@ def _publish_filters_applied(dashboard_id: int, permalink_key: str) -> bool:
from superset.websocket.channel import get_realtime_principal
try:
+ if not current_app.config.get("WEBSOCKET_ENABLE"):
Review Comment:
Valid. The websocket channel cookie is only minted when `can_access_realtime_notifications()` (`can_read` on `Realtime`) passes (`superset/websocket/channel.py`, `set_ws_channel_cookie`), so a caller without it has no socket to receive the nudge. Fixed in 8084c271e59e7d5f51f891489c45505b675c14c9: `_publish_filters_applied` now checks the same permission and returns `False` without publishing when it is missing. Tests cover both the permitted case (publish, `true`) and the missing-permission case (no publish, `false`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): skip dashboard live updates when websockets are disabled [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44796:
URL: https://github.com/apache/superset/pull/44796#issuecomment-5895421556
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): skip dashboard live updates when websockets are disabled [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44796:
URL: https://github.com/apache/superset/pull/44796#issuecomment-5904769049
@gabotorresruiz Pushed 8084c271e5, which skips the live-update publish when the caller lacks `can_read` on `Realtime`, and resolved the review thread about it. A review would be appreciated when you have a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): skip dashboard live updates when websockets are disabled [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44796:
URL: https://github.com/apache/superset/pull/44796#issuecomment-5904684336
@gabotorresruiz CI is green now (the earlier Playwright failure was a job interruption unrelated to this change; every test had passed). Small backend-only change; a review would be appreciated when you have a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): skip dashboard live updates when websockets are disabled [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #44796:
URL: https://github.com/apache/superset/pull/44796#discussion_r4134770979
##########
superset/mcp_service/dashboard/tool/apply_dashboard_filters.py:
##########
@@ -73,6 +74,8 @@ def _publish_filters_applied(dashboard_id: int, permalink_key: str) -> bool:
from superset.websocket.channel import get_realtime_principal
try:
+ if not current_app.config.get("WEBSOCKET_ENABLE"):
Review Comment:
**Suggestion:** When websockets are enabled but the principal lacks `can_read` on `Realtime`, this still publishes and reports success although no authorized browser connection can receive it.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=db4ca8d724da498ca74d8b66d34fc2e5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=db4ca8d724da498ca74d8b66d34fc2e5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/dashboard/tool/apply_dashboard_filters.py
**Line:** 77:77
**Comment:**
*Api Mismatch: When websockets are enabled but the principal lacks `can_read` on `Realtime`, this still publishes and reports success although no authorized browser connection can receive it.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44796&comment_hash=dc15bc2f2ee37c796174957757a1384c65371c353b6ff87fc29e03bb701243da&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44796&comment_hash=dc15bc2f2ee37c796174957757a1384c65371c353b6ff87fc29e03bb701243da&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org