You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "lukaszlenart (via GitHub)" <gi...@apache.org> on 2026/02/24 14:13:52 UTC

[PR] fix: resolve critical nullability/NPE warnings from Qodana CI [struts-intellij-plugin]

lukaszlenart opened a new pull request, #51:
URL: https://github.com/apache/struts-intellij-plugin/pull/51

   ## Summary
   
   - Resolve 21 critical nullability/NPE warnings identified by Qodana CI across 15 source files
   - Add null guards for `DomElement.getXmlTag()`, `PsiClass.getName()`, `PathReference.resolve()` and other `@Nullable` return values passed to `@NotNull` parameters
   - Replace `FileTypes.UNKNOWN.getIcon()` (nullable) with `AllIcons.FileTypes.Unknown` (guaranteed non-null)
   - Fix `@Nullable` annotation on `StrutsDataModel.createGroupNodeRealizer()` override that always returns non-null
   
   ## Test plan
   
   - [x] `./gradlew compileJava` — compilation succeeds with no new warnings
   - [x] `./gradlew test -x rat` — all existing tests pass with no regressions
   - [ ] Verify Qodana annotation count drops from 43 to ~22 (remaining: generated code, capitalization, deprecation, unstable API)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: resolve critical nullability/NPE warnings from Qodana CI [struts-intellij-plugin]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51:
URL: https://github.com/apache/struts-intellij-plugin/pull/51#issuecomment-3952307973

   # Qodana for JVM
   
   **It seems all right 👌**
   
   No new problems were found according to the checks applied
   
   💡 Qodana analysis was run in the pull request mode: only the changed files were checked
   <details>
   <summary>View the detailed Qodana report</summary>
   
   To be able to view the detailed Qodana report, you can either:
     - Register at [Qodana Cloud](https://qodana.cloud/) and [configure the action](https://github.com/jetbrains/qodana-action#qodana-cloud)
     - Use [GitHub Code Scanning with Qodana](https://github.com/jetbrains/qodana-action#github-code-scanning)
     - Host [Qodana report at GitHub Pages](https://github.com/JetBrains/qodana-action/blob/3a8e25f5caad8d8b01c1435f1ef7b19fe8b039a0/README.md#github-pages)
     - Inspect and use `qodana.sarif.json` (see [the Qodana SARIF format](https://www.jetbrains.com/help/qodana/qodana-sarif-output.html#Report+structure) for details)
   
   To get `*.log` files or any other Qodana artifacts, run the action with `upload-result` option set to `true`, 
   so that the action will upload the files as the job artifacts:
   ```yaml
         - name: 'Qodana Scan'
           uses: JetBrains/qodana-action@v2025.3.1
           with:
             upload-result: true
   ```
   
   </details>
   
   <details>
   <summary>Contact Qodana team</summary>
   
   Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com)
     - Or via our issue tracker: https://jb.gg/qodana-issue
     - Or share your feedback: https://jb.gg/qodana-discussions
   </details>
   <!-- JetBrains/qodana-action@v2025.3.1 : Qodana for JVM,  -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: resolve critical nullability/NPE warnings from Qodana CI [struts-intellij-plugin]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51:
URL: https://github.com/apache/struts-intellij-plugin/pull/51#issuecomment-3952242573

   <!-- plugin-artifact-comment -->
   🔌 **Plugin artifact ready for testing!**
   
   Download from [Actions artifacts](https://github.com/apache/struts-intellij-plugin/actions/runs/22354598770#artifacts)
   
   Artifact: `struts2-253.18970.1`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: resolve critical nullability/NPE warnings from Qodana CI [struts-intellij-plugin]

Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart merged PR #51:
URL: https://github.com/apache/struts-intellij-plugin/pull/51


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org